From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#26126: 26.0.50; file-notify-rm-watch removes arbitrary watches Date: Sat, 25 Mar 2017 09:35:53 +0300 Message-ID: <83zig9c186.fsf@gnu.org> References: <87r31x9ulw.fsf@luca> <87shmcney8.fsf@detlef> <87efxw7xvc.fsf@luca> <87mvcjophx.fsf@detlef> <87tw6rssoi.fsf@luca> <87pohfkmvh.fsf@detlef> <87lgs2sobr.fsf@luca> <87y3w2gywc.fsf@detlef> <8737e8excq.fsf@luca> <877f3el80j.fsf@luca> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1490423835 23420 195.159.176.226 (25 Mar 2017 06:37:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 25 Mar 2017 06:37:15 +0000 (UTC) Cc: 26126@debbugs.gnu.org, michael.albinus@gmx.de To: Andreas Politz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 25 07:37:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crfK1-00052t-Dg for geb-bug-gnu-emacs@m.gmane.org; Sat, 25 Mar 2017 07:37:09 +0100 Original-Received: from localhost ([::1]:36145 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crfK4-0007Jl-0o for geb-bug-gnu-emacs@m.gmane.org; Sat, 25 Mar 2017 02:37:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53256) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crfJy-0007Jg-1Z for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2017 02:37:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1crfJu-0004pN-SV for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2017 02:37:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44962) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1crfJu-0004pF-Oc for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2017 02:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1crfJu-0006FE-GV for bug-gnu-emacs@gnu.org; Sat, 25 Mar 2017 02:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2017 06:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26126 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26126-submit@debbugs.gnu.org id=B26126.149042377023937 (code B ref 26126); Sat, 25 Mar 2017 06:37:02 +0000 Original-Received: (at 26126) by debbugs.gnu.org; 25 Mar 2017 06:36:10 +0000 Original-Received: from localhost ([127.0.0.1]:43161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crfJ4-0006E1-2f for submit@debbugs.gnu.org; Sat, 25 Mar 2017 02:36:10 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crfJ2-0006Dp-KQ for 26126@debbugs.gnu.org; Sat, 25 Mar 2017 02:36:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1crfIu-0004PP-Dc for 26126@debbugs.gnu.org; Sat, 25 Mar 2017 02:36:03 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crfIu-0004P0-34; Sat, 25 Mar 2017 02:36:00 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4403 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1crfIs-0005Xs-BW; Sat, 25 Mar 2017 02:35:59 -0400 In-reply-to: <877f3el80j.fsf@luca> (message from Andreas Politz on Fri, 24 Mar 2017 21:44:28 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130911 Archived-At: > From: Andreas Politz > Date: Fri, 24 Mar 2017 21:44:28 +0100 > Cc: 26126@debbugs.gnu.org > > I also thought about the test-cases and more generally about how to > develop a specification for this library, i.e. how do we want this to > behave. Do we have the desire that it works uniformly across all > participating back-ends ? In general, yes. > And is that even possible ? Almost. Some corner cases (like what happens when the watched directory is deleted) behave differently. > One way to go about this would be to write a series of definitive > unit-tests which specify the intended behavior. Then, allow them to fail > for a specific back-end, until someone has fixed potential bugs for it > and confirmed that the test succeeds. That's how these tests were developed. What you see is the result; if you have specific comments about some known failures, please spell them out. > Anyway, I was bored today, so I took a look at what events these > libraries actually produce, the result of which you may also find below. Thanks, but I have difficulty reading it. Could you please provide a short legend? > Finally, I'm tempted to suggest to get rid of the flags argument of > file-notify-add-watch. As it is, things are already complicated enough > and we don't seem to have many people working on this. I think we could > make it backward-compatible to a certain degree. Note also, that many > file operations trigger both kinds of events anyway. The flags are there for the operations where the differences matter.