From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#26835: 26.0.50; url-retrieve no longer raises certificate errors Date: Wed, 10 May 2017 19:48:32 +0300 Message-ID: <83ziekac9r.fsf@gnu.org> References: <8337cfcgr2.fsf@gnu.org> <83lgq5c40b.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1494435013 31482 195.159.176.226 (10 May 2017 16:50:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 10 May 2017 16:50:13 +0000 (UTC) Cc: 26835@debbugs.gnu.org, aaronjensen@gmail.com To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 10 18:50:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8UoT-00084N-7p for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 May 2017 18:50:09 +0200 Original-Received: from localhost ([::1]:43802 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8UoY-0003Cx-SF for geb-bug-gnu-emacs@m.gmane.org; Wed, 10 May 2017 12:50:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37494) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8UoQ-0003Bc-C9 for bug-gnu-emacs@gnu.org; Wed, 10 May 2017 12:50:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8UoM-0006Jx-Im for bug-gnu-emacs@gnu.org; Wed, 10 May 2017 12:50:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34291) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8UoM-0006Jr-Fu for bug-gnu-emacs@gnu.org; Wed, 10 May 2017 12:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d8UoM-0006Jy-7R for bug-gnu-emacs@gnu.org; Wed, 10 May 2017 12:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 May 2017 16:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26835 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security Original-Received: via spool by 26835-submit@debbugs.gnu.org id=B26835.149443494324200 (code B ref 26835); Wed, 10 May 2017 16:50:02 +0000 Original-Received: (at 26835) by debbugs.gnu.org; 10 May 2017 16:49:03 +0000 Original-Received: from localhost ([127.0.0.1]:36960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8UnL-0006Hm-ON for submit@debbugs.gnu.org; Wed, 10 May 2017 12:49:03 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8UnH-0006HX-Of for 26835@debbugs.gnu.org; Wed, 10 May 2017 12:48:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8Un8-000608-5h for 26835@debbugs.gnu.org; Wed, 10 May 2017 12:48:50 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34387) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8Un8-000604-2L; Wed, 10 May 2017 12:48:46 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4461 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1d8Un7-0002XQ-9f; Wed, 10 May 2017 12:48:45 -0400 In-reply-to: (message from Lars Ingebrigtsen on Wed, 10 May 2017 16:24:13 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132432 Archived-At: > From: Lars Ingebrigtsen > Cc: Aaron Jensen , 26835@debbugs.gnu.org > Date: Wed, 10 May 2017 16:24:13 +0200 > > >> (setq gnutls-verify-error t) > >> (url-retrieve-synchronously "https://wrong.host.badssl.com/") > >> > >> In Emacs 25.2, this causes an error to be thrown when you use > >> url-retrieve, in 26, it silently proceeds. > > > > That's because we now perform GnuTLS negotiation asynchronously, > > without blocking. > > (As an aside, perhaps url-retrieve-synchronously should be opening the > socket with :nowait nil?) Yes, I had a similar thought while I was reading the code. > Good analysis. I'll try to have a look at this soonish (and make it > report the error properly) unless somebody else beats me to it. Thanks.