From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: acm@muc.de, 29478@debbugs.gnu.org, npostavs@users.sourceforge.net
Subject: bug#29478: [Patch] bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event
Date: Sat, 06 Jan 2018 19:40:57 +0200 [thread overview]
Message-ID: <83zi5q997a.fsf@gnu.org> (raw)
In-Reply-To: <jwva7xv8une.fsf-monnier+emacsbugs@gnu.org> (message from Stefan Monnier on Tue, 02 Jan 2018 22:56:55 -0500)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: acm@muc.de, 29478@debbugs.gnu.org, npostavs@users.sourceforge.net
> Date: Tue, 02 Jan 2018 22:56:55 -0500
>
> > This patch doesn't apply to the master branch, so I couldn't test it.
>
> It was meant to be read rather than to be applied.
Sorry, I'm not good at reading such large patches.
> If you want a patch that applies, the one below should work.
Thanks. It needs some more work. E.g., "C-h k C-mouse-1" signals an
error:
help-fns--analyze-function: Symbol’s function definition is void: nil
and "C-h k C-mouse-3" followed by a menu selection asks for another
key or mouse click, although it already has got a full key sequence.
In general, I see the idea is to show both down-mouse-N event and
mouse-N event, both with "C-h c" and "C-h k". That could be okay, but
why show undefined sequences? E.g, "C-h c S-mouse-1" shows this in
the echo area:
<S-down-mouse-1> at that spot runs the command mouse-appearance-menu
<S-mouse-1> at that spot is undefined
I'd expect the second line not to appear.
Also, if both events are bound, I think we should show the mouse-N
event before the down-mouse-N event, because the former is much more
important and normally is the one that's bound.
Thanks.
next prev parent reply other threads:[~2018-01-06 17:40 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 23:21 bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event Drew Adams
2017-11-28 1:50 ` Noam Postavsky
2017-11-28 17:11 ` Eli Zaretskii
2017-11-28 22:10 ` Alan Mackenzie
2017-11-29 0:44 ` Noam Postavsky
2017-11-29 3:36 ` Eli Zaretskii
2017-11-29 4:33 ` Drew Adams
2017-12-01 8:31 ` Eli Zaretskii
2017-12-09 17:18 ` Alan Mackenzie
2017-12-23 14:28 ` bug#29478: [Patch 2]: " Alan Mackenzie
2017-12-23 14:48 ` Andreas Schwab
2017-12-24 8:43 ` Alan Mackenzie
[not found] ` <<20171128221036.GC14868@ACM>
[not found] ` <<bbcb1d00-a728-4b5e-b65f-bd2b168c4a51@default>
[not found] ` <<83o9ni3l3i.fsf@gnu.org>
2017-12-01 15:35 ` Drew Adams
2017-12-01 16:51 ` Eli Zaretskii
2017-12-09 16:13 ` Eli Zaretskii
2017-12-09 17:23 ` Alan Mackenzie
2017-12-22 22:05 ` Alan Mackenzie
2017-12-23 9:42 ` Eli Zaretskii
2017-12-23 11:17 ` bug#29478: [Patch] " Alan Mackenzie
2017-12-23 12:41 ` Eli Zaretskii
2017-12-23 16:33 ` Stefan Monnier
2017-12-23 21:04 ` Alan Mackenzie
2017-12-24 4:55 ` Stefan Monnier
2017-12-24 5:41 ` Eli Zaretskii
2017-12-24 6:52 ` Stefan Monnier
2017-12-24 11:48 ` Alan Mackenzie
2017-12-24 15:41 ` Stefan Monnier
2017-12-30 10:50 ` Eli Zaretskii
2018-01-03 3:56 ` Stefan Monnier
2018-01-06 17:40 ` Eli Zaretskii [this message]
2018-01-07 15:31 ` bug#29478: [SUSPECTED SPAM] " Stefan Monnier
2018-01-07 17:46 ` Eli Zaretskii
2018-01-07 18:03 ` Stefan Monnier
2018-01-26 22:00 ` bug#29478: " Stefan Monnier
2018-01-26 22:37 ` Stefan Monnier
2018-01-27 8:28 ` Eli Zaretskii
2018-01-28 16:02 ` Stefan Monnier
2018-01-28 17:18 ` Eli Zaretskii
2018-01-29 21:54 ` Stefan Monnier
2018-01-30 3:23 ` Eli Zaretskii
2018-01-30 14:18 ` Stefan Monnier
2018-01-30 15:40 ` Eli Zaretskii
2018-01-30 16:59 ` Stefan Monnier
2018-01-27 7:59 ` Eli Zaretskii
2017-12-30 10:51 ` Eli Zaretskii
2017-12-30 11:32 ` Alan Mackenzie
2017-12-30 12:49 ` Eli Zaretskii
2017-12-23 16:19 ` bug#29478: " Stefan Monnier
2020-08-26 13:43 ` bug#29478: 26.0.90; " Lars Ingebrigtsen
2020-08-26 17:12 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zi5q997a.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=29478@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=monnier@iro.umontreal.ca \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.