From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30141: (26.0.91; text-pixel dimensions not properly saved by desktop-save-mode sometimes) Date: Sat, 20 Jan 2018 12:50:38 +0200 Message-ID: <83zi58st1d.fsf@gnu.org> References: <5A5F1397.2050001@gmx.at> <5A623F19.6080608@gmx.at> <5A631B5D.2090604@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1516445420 16041 195.159.176.226 (20 Jan 2018 10:50:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 20 Jan 2018 10:50:20 +0000 (UTC) Cc: 30141@debbugs.gnu.org, aaronjensen@gmail.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 20 11:50:15 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecqit-0003QN-G6 for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Jan 2018 11:50:07 +0100 Original-Received: from localhost ([::1]:59087 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecqkt-0000ZQ-Mf for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Jan 2018 05:52:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecqkn-0000Yp-Ak for bug-gnu-emacs@gnu.org; Sat, 20 Jan 2018 05:52:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecqkk-0007aZ-8p for bug-gnu-emacs@gnu.org; Sat, 20 Jan 2018 05:52:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55928) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ecqkk-0007aO-4u for bug-gnu-emacs@gnu.org; Sat, 20 Jan 2018 05:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ecqkj-0005b8-Sw for bug-gnu-emacs@gnu.org; Sat, 20 Jan 2018 05:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Jan 2018 10:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30141-submit@debbugs.gnu.org id=B30141.151644546821449 (code B ref 30141); Sat, 20 Jan 2018 10:52:01 +0000 Original-Received: (at 30141) by debbugs.gnu.org; 20 Jan 2018 10:51:08 +0000 Original-Received: from localhost ([127.0.0.1]:35592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecqjs-0005Zt-4c for submit@debbugs.gnu.org; Sat, 20 Jan 2018 05:51:08 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ecqjq-0005ZW-Rv for 30141@debbugs.gnu.org; Sat, 20 Jan 2018 05:51:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecqji-0007Ag-AU for 30141@debbugs.gnu.org; Sat, 20 Jan 2018 05:51:01 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50604) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecqji-0007AY-6S; Sat, 20 Jan 2018 05:50:58 -0500 Original-Received: from [176.228.60.248] (port=3612 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ecqjh-0005eR-Gv; Sat, 20 Jan 2018 05:50:58 -0500 In-reply-to: <5A631B5D.2090604@gmx.at> (message from martin rudalics on Sat, 20 Jan 2018 11:35:09 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142317 Archived-At: > Date: Sat, 20 Jan 2018 11:35:09 +0100 > From: martin rudalics > > > The issue is when you have the frame sized to be a > > non-multiple of the font-width (pixel sized), save the desktop, then > > restart emacs and restore the desktop. > > > > At this point you’ll have a pixel width in your frame parameters. > > > > Then if you resize the frame to be a multiple of the font-width and > > save the desktop, you end up writing the previous pixel widths because > > they were in frame parameters and we do not reset them unless you are > > using a non-multiple of the font width. > > > > If that doesn’t make sense I can try and write up a repro when I get a chance. > > Thanks, I understand now. I'm afraid it's the implementation that > doesn't make sense but your patch does and should be applied. I'm not > sure whether we still can do that on the release branch. Eli? Not sure about the release branch. AFAIU, this problem existed since Emacs 24.4, and it rears its ugly head only in the situation described above, where the frame is restored with pixel size that's not a multiple of the default font, and then resized to be an exact multiple before saving it, is that right? If so, it sounds obscure enough for us to be able to live with it until Emacs 27, I think.