From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master fails to build on FreeBSD when ACL support is on Date: Mon, 22 Jan 2018 19:41:49 +0200 Message-ID: <83zi55zt7m.fsf@gnu.org> References: <86o9lua0yx.fsf@phe.ftfl.ca> <834lnly8ht.fsf@gnu.org> <86vafy20sj.fsf@phe.ftfl.ca> <83o9lpuct5.fsf@gnu.org> <83lggtu1qn.fsf@gnu.org> <9dd64b10-78ce-c561-8c51-9e15b11e102c@cs.ucla.edu> <83bmhpt12i.fsf@gnu.org> <867escw93p.fsf@phe.ftfl.ca> <86vafwumqp.fsf@phe.ftfl.ca> <025ce2fd-a69a-12da-ce5b-c894d5636789@cs.ucla.edu> <83372zryx3.fsf@gnu.org> <4928e09c-e747-8754-973f-7b358ca3f5e7@cs.ucla.edu> <83inbtriv1.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1516642863 4559 195.159.176.226 (22 Jan 2018 17:41:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 22 Jan 2018 17:41:03 +0000 (UTC) Cc: jrm@ftfl.ca, ashish@FreeBSD.org, monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 22 18:40:58 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1edg5H-0008E1-W2 for ged-emacs-devel@m.gmane.org; Mon, 22 Jan 2018 18:40:40 +0100 Original-Received: from localhost ([::1]:55475 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edg7I-0006Od-Ae for ged-emacs-devel@m.gmane.org; Mon, 22 Jan 2018 12:42:44 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48979) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edg6g-0006OS-4a for emacs-devel@gnu.org; Mon, 22 Jan 2018 12:42:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edg6c-0005x2-56 for emacs-devel@gnu.org; Mon, 22 Jan 2018 12:42:06 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edg6c-0005wl-1H; Mon, 22 Jan 2018 12:42:02 -0500 Original-Received: from [176.228.60.248] (port=3465 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1edg6b-0003sz-DK; Mon, 22 Jan 2018 12:42:01 -0500 In-reply-to: (message from Paul Eggert on Mon, 22 Jan 2018 09:02:47 -0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222150 Archived-At: > Cc: jrm@ftfl.ca, ashish@FreeBSD.org, monnier@IRO.UMontreal.CA, > emacs-devel@gnu.org > From: Paul Eggert > Date: Mon, 22 Jan 2018 09:02:47 -0800 > > You asked why the two functions are inconsistent, and my answer was that > the inconsistency springs from the fact that they have different APIs. > The two functions would continue to be inconsistent even if we were to > change the behavior in the way that you suggest, since set-file-acl > would inform callers whether ACL setting failed (by returning nil > instead of t), whereas copy-file would not. If consistency is the goal > then we need to change their APIs somehow. Why do we need to inform the callers that ACL setting failed, when we detect that ACLs are not supported by the underlying filesystem? What would be the practical usefulness of such an indication?