From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 19045@debbugs.gnu.org, schwab@linux-m68k.org
Subject: bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow
Date: Tue, 13 Feb 2018 07:40:27 +0200 [thread overview]
Message-ID: <83zi4dxx9w.fsf@gnu.org> (raw)
In-Reply-To: <87h8qlubb4.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 12 Feb 2018 23:50:55 +0200)
> From: Juri Linkov <juri@linkov.net>
> Cc: schwab@linux-m68k.org, 19045@debbugs.gnu.org
> Date: Mon, 12 Feb 2018 23:50:55 +0200
>
> > Even if it's true, it means --follow doesn't do any harm when invoked
> > on directories, and we shouldn't disallow that.
>
> I don't know the reason why disallowing directories was implemented
> in the first place. Maybe ‘git log --follow’ failed on directories
> in some older git versions? Wouldn't it be safer to leave the code
> that checks for directories and doesn't add ‘--follow’ for this case?
Sorry, I was confused and thought that you also added the
non-directory restriction. I agree that we should not modify the code
that checks for directories, certainly not on the release branch.
Thanks.
prev parent reply other threads:[~2018-02-13 5:40 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 17:05 bug#19045: 25.0.50; [PATCH] vc-git-print-log use --follow Óscar Fuentes
2014-11-13 19:07 ` Dmitry Gutov
2014-11-13 21:11 ` Óscar Fuentes
2018-02-03 21:59 ` Juri Linkov
2018-02-04 21:58 ` Juri Linkov
2018-02-04 23:31 ` Dmitry Gutov
2018-02-05 3:39 ` Eli Zaretskii
2018-02-05 8:25 ` Dmitry Gutov
2018-02-05 16:18 ` Eli Zaretskii
2018-02-05 20:11 ` Dmitry Gutov
2018-02-05 21:31 ` Juri Linkov
2018-02-06 20:46 ` Dmitry Gutov
2018-02-06 21:51 ` Juri Linkov
2018-02-08 22:08 ` Dmitry Gutov
2018-02-10 21:14 ` Juri Linkov
2018-02-12 0:18 ` Dmitry Gutov
2018-02-15 22:07 ` Juri Linkov
2018-02-16 8:00 ` Eli Zaretskii
2018-02-16 10:20 ` Dmitry Gutov
2018-02-16 10:52 ` Eli Zaretskii
2018-02-18 0:13 ` Richard Stallman
2018-02-20 20:39 ` Juri Linkov
2018-02-21 3:36 ` Eli Zaretskii
2018-02-05 3:33 ` Eli Zaretskii
2018-02-05 21:17 ` Juri Linkov
2018-02-06 3:40 ` Eli Zaretskii
2018-02-06 21:04 ` Juri Linkov
2018-02-08 15:54 ` Eli Zaretskii
2018-02-08 21:09 ` Juri Linkov
2018-02-09 7:08 ` Eli Zaretskii
2018-02-10 11:07 ` Eli Zaretskii
2018-02-10 21:08 ` Juri Linkov
2018-02-11 16:24 ` Eli Zaretskii
2018-02-11 17:03 ` Andreas Schwab
2018-02-11 17:25 ` Eli Zaretskii
2018-02-11 18:22 ` Andreas Schwab
2018-02-11 18:49 ` Eli Zaretskii
2018-02-11 21:22 ` Juri Linkov
2018-02-12 18:09 ` Eli Zaretskii
2018-02-12 21:50 ` Juri Linkov
2018-02-13 5:40 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zi4dxx9w.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=19045@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.