From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30757: Better manipulation (suppressing, examining type) of warnings from *Warnings* buffer Date: Fri, 09 Mar 2018 18:18:32 +0200 Message-ID: <83zi3husrr.fsf@gnu.org> References: <877eql1ld0.fsf@gmail.com> <871sgtnxth.fsf@gmail.com> <87woylminv.fsf@gmail.com> <873719kzyh.fsf@gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1520612232 16445 195.159.176.226 (9 Mar 2018 16:17:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 9 Mar 2018 16:17:12 +0000 (UTC) Cc: 30757@debbugs.gnu.org, npostavs@gmail.com To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 09 17:17:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euKhe-00048g-Mn for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Mar 2018 17:17:06 +0100 Original-Received: from localhost ([::1]:46244 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euKjh-0008NZ-Ii for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Mar 2018 11:19:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euKjZ-0008Lu-4t for bug-gnu-emacs@gnu.org; Fri, 09 Mar 2018 11:19:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1euKjV-000656-Vl for bug-gnu-emacs@gnu.org; Fri, 09 Mar 2018 11:19:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44817) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1euKjV-00064w-RK for bug-gnu-emacs@gnu.org; Fri, 09 Mar 2018 11:19:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1euKjV-0002Nk-Lk for bug-gnu-emacs@gnu.org; Fri, 09 Mar 2018 11:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Mar 2018 16:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30757 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30757-submit@debbugs.gnu.org id=B30757.15206123259127 (code B ref 30757); Fri, 09 Mar 2018 16:19:01 +0000 Original-Received: (at 30757) by debbugs.gnu.org; 9 Mar 2018 16:18:45 +0000 Original-Received: from localhost ([127.0.0.1]:52713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euKjF-0002N9-0P for submit@debbugs.gnu.org; Fri, 09 Mar 2018 11:18:45 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:41578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euKjD-0002Mw-Kk for 30757@debbugs.gnu.org; Fri, 09 Mar 2018 11:18:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1euKj5-0005wX-BO for 30757@debbugs.gnu.org; Fri, 09 Mar 2018 11:18:38 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38145) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euKj5-0005wS-7Y; Fri, 09 Mar 2018 11:18:35 -0500 Original-Received: from [176.228.60.248] (port=1806 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1euKj4-0006RH-N1; Fri, 09 Mar 2018 11:18:35 -0500 In-reply-to: <873719kzyh.fsf@gmail.com> (message from Robert Pluim on Fri, 09 Mar 2018 16:53:26 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144078 Archived-At: > From: Robert Pluim > Date: Fri, 09 Mar 2018 16:53:26 +0100 > Cc: 30757@debbugs.gnu.org > > Here's what I've got so far. Suggestions welcome for wording, style > changes, etc. Thanks. > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -71,6 +71,12 @@ moved to the early init file (see above). > > * Changes in Emacs 27.1 > > ++++ "+++" means this change was documented in the manual(s), but this change wasn't, AFAIU. Shkuld this be documented in the ELisp manual? > +** Warning types can now be disabled from the warning buffer. > +For each warning 'display-warning' now adds buttons to the buffer it > +uses to allow permanent suppression of the warning popup or of the > +warning itself. This entry should be made more clear. "Warning types" is never explained, the reference to 'display-warning' is confusing (this is a user-level feature, so why mention the function which is involved?), it is unclear what buffer is alluded to by "the buffer it uses", and the difference between "warning popup" and "warning itself" is left unexplained. > +(define-button-type 'warning-suppress-warning > + 'action #'warning-suppress-action > + 'help-echo "mouse-2, RET: Permanently disable popping up this warning") > +(defun warning-suppress-action (button) > + (customize-save-variable 'warning-suppress-types > + (cons (list (button-get button 'warning-type)) > + warning-suppress-types))) > +(define-button-type 'warning-suppress-log-warning > + 'action #'warning-suppress-log-action > + 'help-echo "mouse-2, RET: Never generate this warning") Likewise here: the difference between "disable popping up" and "never generate" is unclear. maybe a different wording will clarify that, but I cannot suggest one because frankly I don't understand well enough what each one does.