From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30343: make transpose-regions interactive Date: Sat, 10 Mar 2018 14:02:01 +0200 Message-ID: <83zi3gt9za.fsf@gnu.org> References: <83h8qp2jsg.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1520683271 22578 195.159.176.226 (10 Mar 2018 12:01:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 10 Mar 2018 12:01:11 +0000 (UTC) Cc: 30343@debbugs.gnu.org To: charles@aurox.ch (Charles A. Roelli) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 10 13:01:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eudBS-0005lu-ID for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Mar 2018 13:01:06 +0100 Original-Received: from localhost ([::1]:50393 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eudDV-0003SM-6l for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Mar 2018 07:03:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eudDP-0003SH-Ax for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 07:03:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eudDK-0002Gm-Fv for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 07:03:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45284) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eudDK-0002Ge-C3 for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 07:03:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eudDK-0003Dx-3U for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 07:03:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Mar 2018 12:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30343 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 30343-submit@debbugs.gnu.org id=B30343.152068333212330 (code B ref 30343); Sat, 10 Mar 2018 12:03:02 +0000 Original-Received: (at 30343) by debbugs.gnu.org; 10 Mar 2018 12:02:12 +0000 Original-Received: from localhost ([127.0.0.1]:53181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eudCW-0003Co-5e for submit@debbugs.gnu.org; Sat, 10 Mar 2018 07:02:12 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eudCU-0003Cb-VL for 30343@debbugs.gnu.org; Sat, 10 Mar 2018 07:02:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eudCL-00022P-Ah for 30343@debbugs.gnu.org; Sat, 10 Mar 2018 07:02:06 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eudCL-00022K-72; Sat, 10 Mar 2018 07:02:01 -0500 Original-Received: from [176.228.60.248] (port=3038 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eudCK-0005CD-KG; Sat, 10 Mar 2018 07:02:01 -0500 In-reply-to: (charles@aurox.ch) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144104 Archived-At: > Date: Wed, 07 Mar 2018 21:56:28 +0100 > From: charles@aurox.ch (Charles A. Roelli) > CC: 30343@debbugs.gnu.org > > Thanks for the review. Could you please look at the following second > iteration? All your points should be addressed. This LGTM, thanks. One minor comment: > +Interactively, STARTR1 and ENDR1 are point and mark; STARTR2 and ENDR2 > +are the last two marks pushed to the mark ring; LEAVE-MARKERS is nil. > +If a prefix argument N is given, STARTR2 and ENDR2 are the two > +successive marks N entries backwards in the mark ring. A negative > +prefix argument instead counts forwards from the oldest mark in the Please use "back" in "forward" here, instead of "backwards" and "forwards". ("Backwards" has a meaning that might confuse readers here.)