From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30938: 27.0; `dired-do-create-files' etc.: do NOT always raise error if no files Date: Sun, 25 Mar 2018 19:50:41 +0300 Message-ID: <83zi2wf6am.fsf@gnu.org> References: <7ea429b5-b12e-4639-9d77-11db71504d9c@default> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1521996552 19873 195.159.176.226 (25 Mar 2018 16:49:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 25 Mar 2018 16:49:12 +0000 (UTC) Cc: 30938@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Mar 25 18:49:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f08pP-00054M-FI for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Mar 2018 18:49:07 +0200 Original-Received: from localhost ([::1]:51916 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f08rS-0005z9-Mr for geb-bug-gnu-emacs@m.gmane.org; Sun, 25 Mar 2018 12:51:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f08rJ-0005yz-4l for bug-gnu-emacs@gnu.org; Sun, 25 Mar 2018 12:51:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f08rF-0006XU-UD for bug-gnu-emacs@gnu.org; Sun, 25 Mar 2018 12:51:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45246) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f08rF-0006XK-Pl for bug-gnu-emacs@gnu.org; Sun, 25 Mar 2018 12:51:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f08rF-0004Fu-J8 for bug-gnu-emacs@gnu.org; Sun, 25 Mar 2018 12:51:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Mar 2018 16:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30938 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30938-submit@debbugs.gnu.org id=B30938.152199664316333 (code B ref 30938); Sun, 25 Mar 2018 16:51:01 +0000 Original-Received: (at 30938) by debbugs.gnu.org; 25 Mar 2018 16:50:43 +0000 Original-Received: from localhost ([127.0.0.1]:53143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f08qx-0004FN-Iu for submit@debbugs.gnu.org; Sun, 25 Mar 2018 12:50:43 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f08qw-0004F9-7w for 30938@debbugs.gnu.org; Sun, 25 Mar 2018 12:50:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f08qn-0006Cw-Vl for 30938@debbugs.gnu.org; Sun, 25 Mar 2018 12:50:37 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42235) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f08qn-0006Cm-Rx; Sun, 25 Mar 2018 12:50:33 -0400 Original-Received: from [176.228.60.248] (port=1960 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f08qn-0001o9-Ac; Sun, 25 Mar 2018 12:50:33 -0400 In-reply-to: <7ea429b5-b12e-4639-9d77-11db71504d9c@default> (message from Drew Adams on Sun, 25 Mar 2018 09:36:08 -0700 (PDT)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144605 Archived-At: > Date: Sun, 25 Mar 2018 09:36:08 -0700 (PDT) > From: Drew Adams > > The bug is that calls to `dired-get-marked-files' have been changed all > over the place to systematically pass a non-nil value for optional arg > ERROR. In general, this is completely inappropriate when the command > invoking `dired-get-marked-files' is not called interactively. > > There is NO reason to suppose that a `user-error' occurred when a given > command is invoked non-interactively. > > The logic behind this change is wrong - much too simplistic. A non-nil > ERROR arg should perhaps be passed when called from some commands, but > typically only when such a command is called interactively. Only then > might Emacs legitimately assume (and even this is arguable, in general) > that the user has committed an error. Please provide at least one example (preferably more than one) of a real-life use case where these changes get in the way.