From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30955: 27.0.50; Mouse clicks on header-line in Info are broken Date: Sat, 31 Mar 2018 20:18:19 +0300 Message-ID: <83zi2o6u5g.fsf@gnu.org> References: <83po3qga5g.fsf@gnu.org> <838tabdu3x.fsf@gnu.org> <83y3ibcbms.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1522516635 13878 195.159.176.226 (31 Mar 2018 17:17:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 31 Mar 2018 17:17:15 +0000 (UTC) Cc: m43cap@yandex.com, 30955@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 31 19:17:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f2K7p-0003TF-Hu for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Mar 2018 19:17:10 +0200 Original-Received: from localhost ([::1]:38639 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f2K9r-00039j-Cf for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Mar 2018 13:19:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f2K9h-00038M-QH for bug-gnu-emacs@gnu.org; Sat, 31 Mar 2018 13:19:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f2K9e-00052c-LS for bug-gnu-emacs@gnu.org; Sat, 31 Mar 2018 13:19:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53517) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f2K9e-00052F-HK for bug-gnu-emacs@gnu.org; Sat, 31 Mar 2018 13:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f2K9e-0006wJ-8B for bug-gnu-emacs@gnu.org; Sat, 31 Mar 2018 13:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Mar 2018 17:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30955 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30955-submit@debbugs.gnu.org id=B30955.152251671426642 (code B ref 30955); Sat, 31 Mar 2018 17:19:02 +0000 Original-Received: (at 30955) by debbugs.gnu.org; 31 Mar 2018 17:18:34 +0000 Original-Received: from localhost ([127.0.0.1]:33181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f2K9B-0006vd-TH for submit@debbugs.gnu.org; Sat, 31 Mar 2018 13:18:34 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f2K9B-0006vR-0f for 30955@debbugs.gnu.org; Sat, 31 Mar 2018 13:18:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f2K94-0004BR-J2 for 30955@debbugs.gnu.org; Sat, 31 Mar 2018 13:18:27 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54649) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f2K8x-0003yp-SN; Sat, 31 Mar 2018 13:18:19 -0400 Original-Received: from [176.228.60.248] (port=2956 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f2K8x-0005ef-9W; Sat, 31 Mar 2018 13:18:19 -0400 In-reply-to: (message from Stefan Monnier on Thu, 29 Mar 2018 09:11:41 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144766 Archived-At: > From: Stefan Monnier > Cc: 30955@debbugs.gnu.org, m43cap@yandex.com > Date: Thu, 29 Mar 2018 09:11:41 -0400 > > >> There's indeed a bug, here, which is that it says > >> > >> (translated from ) > >> > >> instead of > >> > >> (translated from ) > >> > >> I assume it's because the fix I installed modifies the event in-place, > >> so the recording of "untranslated events" gets changed by side-effect. > > > > I don't think so: I saw the mouse-2 part even before you fixed the > > problem. > > Maybe you've seen it with yet-older code, such as the one in the > emacs-26 branch (in that code, the mouse-1 => mouse-2 remapping was done > elsewhere (i.e. as part of the processing of down-mouse-1) so > read_key_sequence never even saw the mouse-1 event to put it into the > raw_keybuf)? > > > So I think it's something else at work. > > Yet the second hunk below does fix this problem (the first hunk fixes > the same problem but for C-h l, and the third just removes code which > does something wrong, and I have no idea why the code was there in the > first place). AFAICT, this patch is now installed on master, but I still see the same issue: "C-h c" reports mouse-2 whereas I click mouse-1. Was this issue supposed to be resolved, and if so, what am I missing?