From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: m43cap@yandex.com, 30955@debbugs.gnu.org
Subject: bug#30955: 27.0.50; Mouse clicks on header-line in Info are broken
Date: Sat, 31 Mar 2018 20:18:19 +0300 [thread overview]
Message-ID: <83zi2o6u5g.fsf@gnu.org> (raw)
In-Reply-To: <jwvlgeb83pb.fsf-monnier+emacsbugs@gnu.org> (message from Stefan Monnier on Thu, 29 Mar 2018 09:11:41 -0400)
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: 30955@debbugs.gnu.org, m43cap@yandex.com
> Date: Thu, 29 Mar 2018 09:11:41 -0400
>
> >> There's indeed a bug, here, which is that it says
> >>
> >> (translated from <mouse-2>)
> >>
> >> instead of
> >>
> >> (translated from <mouse-1>)
> >>
> >> I assume it's because the fix I installed modifies the event in-place,
> >> so the recording of "untranslated events" gets changed by side-effect.
> >
> > I don't think so: I saw the mouse-2 part even before you fixed the
> > problem.
>
> Maybe you've seen it with yet-older code, such as the one in the
> emacs-26 branch (in that code, the mouse-1 => mouse-2 remapping was done
> elsewhere (i.e. as part of the processing of down-mouse-1) so
> read_key_sequence never even saw the mouse-1 event to put it into the
> raw_keybuf)?
>
> > So I think it's something else at work.
>
> Yet the second hunk below does fix this problem (the first hunk fixes
> the same problem but for C-h l, and the third just removes code which
> does something wrong, and I have no idea why the code was there in the
> first place).
AFAICT, this patch is now installed on master, but I still see the
same issue: "C-h c" reports mouse-2 whereas I click mouse-1. Was this
issue supposed to be resolved, and if so, what am I missing?
next prev parent reply other threads:[~2018-03-31 17:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 14:54 bug#30955: 27.0.50; Mouse clicks on header-line in Info are broken Eli Zaretskii
2018-03-27 18:46 ` Stefan Monnier
2018-03-27 19:27 ` Stefan Monnier
2018-03-28 6:07 ` Colin Baxter
2018-03-29 11:00 ` Eli Zaretskii
2018-03-29 12:10 ` Stefan Monnier
2018-03-29 12:24 ` Eli Zaretskii
2018-03-29 13:11 ` Stefan Monnier
2018-03-29 13:30 ` Colin Baxter
2018-03-31 17:18 ` Eli Zaretskii [this message]
2018-03-31 18:56 ` Colin Baxter
2018-03-31 19:03 ` Eli Zaretskii
2018-03-31 19:16 ` Eli Zaretskii
2018-03-31 20:59 ` Colin Baxter
2018-03-31 20:55 ` Colin Baxter
2018-03-31 23:40 ` Stefan Monnier
2018-04-01 6:50 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zi2o6u5g.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=30955@debbugs.gnu.org \
--cc=m43cap@yandex.com \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.