From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20493: 25.0.50; next-error in change-log-mode can hide its buffer Date: Fri, 20 Apr 2018 10:57:55 +0300 Message-ID: <83zi1yxqbg.fsf@gnu.org> References: <86h9rtbvvz.fsf@yandex.ru> <87po2xeeol.fsf@mail.linkov.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1524210965 24338 195.159.176.226 (20 Apr 2018 07:56:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 20 Apr 2018 07:56:05 +0000 (UTC) Cc: 20493@debbugs.gnu.org, dgutov@yandex.ru To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 20 09:56:01 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9Qtk-0006BE-Ri for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Apr 2018 09:56:00 +0200 Original-Received: from localhost ([::1]:35897 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9Qvp-0005GS-Re for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Apr 2018 03:58:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9Qvj-0005Fp-L8 for bug-gnu-emacs@gnu.org; Fri, 20 Apr 2018 03:58:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f9Qvi-0002WT-Tz for bug-gnu-emacs@gnu.org; Fri, 20 Apr 2018 03:58:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53812) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f9Qvi-0002W0-QY for bug-gnu-emacs@gnu.org; Fri, 20 Apr 2018 03:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f9Qvi-0004c8-HG for bug-gnu-emacs@gnu.org; Fri, 20 Apr 2018 03:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Apr 2018 07:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20493 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20493-submit@debbugs.gnu.org id=B20493.152421107717726 (code B ref 20493); Fri, 20 Apr 2018 07:58:02 +0000 Original-Received: (at 20493) by debbugs.gnu.org; 20 Apr 2018 07:57:57 +0000 Original-Received: from localhost ([127.0.0.1]:33476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9Qvc-0004bp-UY for submit@debbugs.gnu.org; Fri, 20 Apr 2018 03:57:57 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f9Qvb-0004bc-1T for 20493@debbugs.gnu.org; Fri, 20 Apr 2018 03:57:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f9QvU-00013n-JO for 20493@debbugs.gnu.org; Fri, 20 Apr 2018 03:57:49 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52267) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f9QvN-0000Ja-FP; Fri, 20 Apr 2018 03:57:41 -0400 Original-Received: from [176.228.60.248] (port=3860 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1f9QvM-0003Ri-N0; Fri, 20 Apr 2018 03:57:41 -0400 In-reply-to: <87po2xeeol.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 17 Apr 2018 23:55:06 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:145636 Archived-At: > From: Juri Linkov > Date: Tue, 17 Apr 2018 23:55:06 +0300 > Cc: 20493-done@debbugs.gnu.org > > > next-error-function in *compile* or *grep* works in a certain way: > > > > - It doesn't open the locations when the *compile* buffer is selected, > > it just jumps between them in that buffer. > > > > - When *compile* is visible but displayed a different window, pressing > > C-x ` will never display the "next error" on top of *compile*. So the > > latter always stays visible. > > > > Neither is true of change-log-next-error. > > > > I think we need more consistency in this. > > This is finally implemented. Thanks, but I think the documentation that accompanies these changes should be augmented/improved: . next-error-select-buffer should be documented in the Emacs manual . the doc string of next-error-select-buffer should be expanded to explain the effect of selecting a buffer. The current text is quite cryptic, IMO: "set it as the last used." The meaning of "last used" in this context should be explained. . next-error-find-buffer-function should perhaps be mentioned in the Emacs manual and/or the ELisp manual. . the doc string of next-error-find-buffer-function should describe the arguments with which it is called, what possible values it can return, and the meaning of each returned value. TIA