From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!.POSTED!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [RFC PATCH] Per-window face support
Date: Sat, 16 Jun 2018 13:29:53 +0300
Message-ID: <83zhzvyqfy.fsf@gnu.org>
References: <5e08587a56ad528599ed5fb259be6335.squirrel@dancol.org>
	<83muw5vdtr.fsf@gnu.org>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: blaine.gmane.org
X-Trace: blaine.gmane.org 1529144888 7167 195.159.176.226 (16 Jun 2018 10:28:08 GMT)
X-Complaints-To: usenet@blaine.gmane.org
NNTP-Posting-Date: Sat, 16 Jun 2018 10:28:08 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: dancol@dancol.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 16 12:28:04 2018
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([208.118.235.17])
	by blaine.gmane.org with esmtp (Exim 4.84_2)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1fU8R9-0001kA-8M
	for ged-emacs-devel@m.gmane.org; Sat, 16 Jun 2018 12:28:03 +0200
Original-Received: from localhost ([::1]:50943 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1fU8TG-0007v8-Gc
	for ged-emacs-devel@m.gmane.org; Sat, 16 Jun 2018 06:30:14 -0400
Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51858)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1fU8T8-0007tb-6h
	for emacs-devel@gnu.org; Sat, 16 Jun 2018 06:30:08 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eliz@gnu.org>) id 1fU8T5-0005Ux-2P
	for emacs-devel@gnu.org; Sat, 16 Jun 2018 06:30:06 -0400
Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35064)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>)
	id 1fU8T4-0005Ub-Vi; Sat, 16 Jun 2018 06:30:03 -0400
Original-Received: from [176.228.60.248] (port=3124 helo=home-c4e4a596f7)
	by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
	(Exim 4.82) (envelope-from <eliz@gnu.org>)
	id 1fU8T4-0004mj-7A; Sat, 16 Jun 2018 06:30:02 -0400
In-reply-to: <83muw5vdtr.fsf@gnu.org> (message from Eli Zaretskii on Fri, 08
	Jun 2018 12:15:44 +0300)
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
X-Received-From: 2001:4830:134:3::e
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel/>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Original-Sender: "Emacs-devel" <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Xref: news.gmane.org gmane.emacs.devel:226352
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/226352>

> Date: Fri, 08 Jun 2018 12:15:44 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org

Daniel, you never answered my question below:

> > +    if (w) {
> > +      Lisp_Object found = assq_no_quit (parameter, w->window_parameters);
> > +      if (!NILP (found) && EQ (XCDR (found), value))
> > +        match = true;
> > +    }
> 
> [...]
> 
> Also, I wonder whether EQ should actually be equal_no_quit, because
> the latter would allow parameters with values that are not just
> integers or symbols.

I still wonder why we only allow EQ there, it sounds unnecessarily
restrictive.