From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 Date: Sun, 22 Jul 2018 17:11:43 +0300 Message-ID: <83zhyjweao.fsf@gnu.org> References: <20180619104351.41e4e3d1@malediction> <87efgnm17h.fsf@gmail.com> <831scgn3ig.fsf@gnu.org> <83in5ib53q.fsf@gnu.org> <83muum1d3m.fsf@gnu.org> <83effy14p6.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1532268610 11913 195.159.176.226 (22 Jul 2018 14:10:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 22 Jul 2018 14:10:10 +0000 (UTC) Cc: mk.fraggod@gmail.com, npostavs@gmail.com, 31901@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 22 16:10:06 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhF3l-0002z5-TL for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Jul 2018 16:10:06 +0200 Original-Received: from localhost ([::1]:56148 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhF5s-00061N-RK for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Jul 2018 10:12:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhF5j-00061D-BK for bug-gnu-emacs@gnu.org; Sun, 22 Jul 2018 10:12:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhF5e-0001RP-Ev for bug-gnu-emacs@gnu.org; Sun, 22 Jul 2018 10:12:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47460) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fhF5e-0001RI-9Z for bug-gnu-emacs@gnu.org; Sun, 22 Jul 2018 10:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fhF5e-0000O4-1g for bug-gnu-emacs@gnu.org; Sun, 22 Jul 2018 10:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Jul 2018 14:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31901 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 31901-submit@debbugs.gnu.org id=B31901.15322687111467 (code B ref 31901); Sun, 22 Jul 2018 14:12:02 +0000 Original-Received: (at 31901) by debbugs.gnu.org; 22 Jul 2018 14:11:51 +0000 Original-Received: from localhost ([127.0.0.1]:52477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhF5S-0000Nb-Pg for submit@debbugs.gnu.org; Sun, 22 Jul 2018 10:11:50 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fhF5R-0000NM-5b for 31901@debbugs.gnu.org; Sun, 22 Jul 2018 10:11:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhF5H-0001ML-0c for 31901@debbugs.gnu.org; Sun, 22 Jul 2018 10:11:43 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47325) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhF5G-0001MH-Ta; Sun, 22 Jul 2018 10:11:38 -0400 Original-Received: from [176.228.60.248] (port=4354 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fhF5G-0001yD-A9; Sun, 22 Jul 2018 10:11:38 -0400 In-reply-to: (message from Lars Ingebrigtsen on Sun, 22 Jul 2018 13:40:51 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148810 Archived-At: > From: Lars Ingebrigtsen > Cc: mk.fraggod@gmail.com, npostavs@gmail.com, 31901@debbugs.gnu.org > Date: Sun, 22 Jul 2018 13:40:51 +0200 > > OK, I've now fixed the async error case (on master), I think: > > (process-live-p socket) > nil > (process-status socket) > file-missing Thanks! > I've fixed this on master, because I'm not 100% sure that my fix is > completely correct. Should we perhaps also call a sentinel in the async > error case? But we didn't call the sentinel before, did we? > But we should, in any case, perhaps cherry-pick this fix into Emacs > 26.2. It looks like the only visible change in behavior is that we now store the error in the process object, is that right? If so, I think we want this on emacs-26, yes.