Version tags for cus-start.el options

Version tags for cus-start.el options

[Eli Zaretskii]

I noticed that options that are defined in C don't have the "This
variable was first introduced..." part in the *Help* buffer, even if
cus-start.el does state the version for them.  Why is that?  And
customize-changed-options does somehow discover the version for those
variables, because it offers them in the buffer it creates.

So I wonder why don't show this info in *Help*.  Is it a bug?

Re: Version tags for cus-start.el options

[Eli Zaretskii]

> Date: Sat, 11 Aug 2018 13:14:40 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> I noticed that options that are defined in C don't have the "This
> variable was first introduced..." part in the *Help* buffer, even if
> cus-start.el does state the version for them.  Why is that?  And
> customize-changed-options does somehow discover the version for those
> variables, because it offers them in the buffer it creates.
> 
> So I wonder why don't show this info in *Help*.  Is it a bug?

Looks like a bug, yes.  Does anyone see anything wrong with the patch
below?

diff --git a/lisp/cus-start.el b/lisp/cus-start.el
index 1a5b3ca..88a6175 100644
--- a/lisp/cus-start.el
+++ b/lisp/cus-start.el
@@ -711,6 +711,8 @@ minibuffer-prompt-properties--setter
 	  (put symbol 'risky-local-variable (cadr prop)))
       (if (setq prop (memq :set rest))
 	  (put symbol 'custom-set (cadr prop)))
+      ;; This is used by describe-variable.
+      (if version (put symbol 'custom-version version))
       ;; Don't re-add to custom-delayed-init-variables post-startup.
       (unless after-init-time
 	;; Note this is the _only_ initialize property we handle.
@@ -731,7 +733,6 @@ minibuffer-prompt-properties--setter
 	  (custom-add-to-group group symbol 'custom-variable))
 	;; Set the type.
 	(put symbol 'custom-type type)
-	(if version (put symbol 'custom-version version))
 	(while rest
 	  (setq prop (car rest)
 		propval (cadr rest)

Re: Version tags for cus-start.el options

[Eli Zaretskii]

> Date: Sat, 01 Sep 2018 15:49:19 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > Date: Sat, 11 Aug 2018 13:14:40 +0300
> > From: Eli Zaretskii <eliz@gnu.org>
> > 
> > I noticed that options that are defined in C don't have the "This
> > variable was first introduced..." part in the *Help* buffer, even if
> > cus-start.el does state the version for them.  Why is that?  And
> > customize-changed-options does somehow discover the version for those
> > variables, because it offers them in the buffer it creates.
> > 
> > So I wonder why don't show this info in *Help*.  Is it a bug?
> 
> Looks like a bug, yes.  Does anyone see anything wrong with the patch
> below?

No objections, so I pushed this to the emacs-26 branch.