all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: emacs-devel@gnu.org
Subject: Re: Version tags for cus-start.el options
Date: Sat, 01 Sep 2018 15:49:19 +0300	[thread overview]
Message-ID: <83zhx11iy8.fsf@gnu.org> (raw)
In-Reply-To: <8336vlmcq7.fsf@gnu.org> (message from Eli Zaretskii on Sat, 11 Aug 2018 13:14:40 +0300)

> Date: Sat, 11 Aug 2018 13:14:40 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> I noticed that options that are defined in C don't have the "This
> variable was first introduced..." part in the *Help* buffer, even if
> cus-start.el does state the version for them.  Why is that?  And
> customize-changed-options does somehow discover the version for those
> variables, because it offers them in the buffer it creates.
> 
> So I wonder why don't show this info in *Help*.  Is it a bug?

Looks like a bug, yes.  Does anyone see anything wrong with the patch
below?

diff --git a/lisp/cus-start.el b/lisp/cus-start.el
index 1a5b3ca..88a6175 100644
--- a/lisp/cus-start.el
+++ b/lisp/cus-start.el
@@ -711,6 +711,8 @@ minibuffer-prompt-properties--setter
 	  (put symbol 'risky-local-variable (cadr prop)))
       (if (setq prop (memq :set rest))
 	  (put symbol 'custom-set (cadr prop)))
+      ;; This is used by describe-variable.
+      (if version (put symbol 'custom-version version))
       ;; Don't re-add to custom-delayed-init-variables post-startup.
       (unless after-init-time
 	;; Note this is the _only_ initialize property we handle.
@@ -731,7 +733,6 @@ minibuffer-prompt-properties--setter
 	  (custom-add-to-group group symbol 'custom-variable))
 	;; Set the type.
 	(put symbol 'custom-type type)
-	(if version (put symbol 'custom-version version))
 	(while rest
 	  (setq prop (car rest)
 		propval (cadr rest)



  reply	other threads:[~2018-09-01 12:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-11 10:14 Version tags for cus-start.el options Eli Zaretskii
2018-09-01 12:49 ` Eli Zaretskii [this message]
2018-09-07  7:37   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zhx11iy8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.