From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 9dd95bf: * lisp/emacs-lisp/pcase.el (pcase--u1): Fix bignums Date: Fri, 26 Oct 2018 18:02:39 +0300 Message-ID: <83zhv0oink.fsf@gnu.org> References: <83bm7hozav.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1540566244 22627 195.159.176.226 (26 Oct 2018 15:04:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 26 Oct 2018 15:04:04 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 26 17:04:00 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gG3eZ-0005if-Th for ged-emacs-devel@m.gmane.org; Fri, 26 Oct 2018 17:04:00 +0200 Original-Received: from localhost ([::1]:60563 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG3gg-0004Vl-7N for ged-emacs-devel@m.gmane.org; Fri, 26 Oct 2018 11:06:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG3dN-0001QC-KI for emacs-devel@gnu.org; Fri, 26 Oct 2018 11:02:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gG3dK-0007x7-Dj for emacs-devel@gnu.org; Fri, 26 Oct 2018 11:02:45 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG3dK-0007vx-5O; Fri, 26 Oct 2018 11:02:42 -0400 Original-Received: from [176.228.60.248] (port=1094 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gG3dI-000083-Ec; Fri, 26 Oct 2018 11:02:41 -0400 In-reply-to: (message from Stefan Monnier on Fri, 26 Oct 2018 10:17:33 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:230707 Archived-At: > From: Stefan Monnier > Cc: emacs-devel@gnu.org > Date: Fri, 26 Oct 2018 10:17:33 -0400 > > > Stefan, this change needs a suitable change in the docs (both the doc > > string and the ELisp manual): they still claim integers are compared > > using 'equal', which AFAIU is now inaccurate. > > AFAIK using `eql` gives the same result as comparing with `equal`: > It's just an internal optimization that is transparent to the user. That's so, but I find documentation that explicitly calls out 'equal' misleading when the code actually invokes 'eql' instead. Maybe we should make the text less explicit then? > So, just like we did not document the fact that integers (and symbols) > where actually compared with `eq` That we already had misleading docs doesn't mean we need to continue having misleading docs.