From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33294: xwidget-insert crashes Emacs Date: Thu, 08 Nov 2018 11:45:28 +0200 Message-ID: <83zhujc37r.fsf@gnu.org> References: <838t25cxft.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1541670244 27084 195.159.176.226 (8 Nov 2018 09:44:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 8 Nov 2018 09:44:04 +0000 (UTC) Cc: 33294@debbugs.gnu.org To: Andy Moreton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 08 10:44:00 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKgr1-0006sZ-29 for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Nov 2018 10:43:59 +0100 Original-Received: from localhost ([::1]:55428 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKgt7-0005mZ-EQ for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Nov 2018 04:46:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKgt1-0005mJ-HM for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 04:46:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKgt0-0004F5-L7 for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 04:46:03 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36054) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gKgt0-0004En-EX for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 04:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gKgt0-0003iF-BF for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 04:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Nov 2018 09:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33294-submit@debbugs.gnu.org id=B33294.154167035814251 (code B ref 33294); Thu, 08 Nov 2018 09:46:02 +0000 Original-Received: (at 33294) by debbugs.gnu.org; 8 Nov 2018 09:45:58 +0000 Original-Received: from localhost ([127.0.0.1]:40312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKgsw-0003hn-5n for submit@debbugs.gnu.org; Thu, 08 Nov 2018 04:45:58 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:48332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKgst-0003hY-Oa for 33294@debbugs.gnu.org; Thu, 08 Nov 2018 04:45:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKgsl-00043Y-Ag for 33294@debbugs.gnu.org; Thu, 08 Nov 2018 04:45:50 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKgsl-00043Q-6r; Thu, 08 Nov 2018 04:45:47 -0500 Original-Received: from [176.228.60.248] (port=4735 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gKgsk-0004tz-OQ; Thu, 08 Nov 2018 04:45:47 -0500 In-reply-to: (message from Andy Moreton on Wed, 07 Nov 2018 16:16:00 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152153 Archived-At: > From: Andy Moreton > Date: Wed, 07 Nov 2018 16:16:00 +0000 > > Unrelated to this bug, but a quick look at the code shows that > xwidget-insert calls make-xwidget, which returns an uninitialized object > if the type argument is not 'webkit. Not sure I follow: this part of the code seems to initialize the object that is returned even if TYPE is not 'webkit': struct xwidget *xw = allocate_xwidget (); Lisp_Object val; xw->type = type; xw->title = title; xw->buffer = NILP (buffer) ? Fcurrent_buffer () : Fget_buffer_create (buffer); xw->height = XFASTINT (height); xw->width = XFASTINT (width); xw->kill_without_query = false; XSETXWIDGET (val, xw); Vxwidget_list = Fcons (val, Vxwidget_list); xw->widgetwindow_osr = NULL; xw->widget_osr = NULL; xw->plist = Qnil;