From: Eli Zaretskii <eliz@gnu.org>
To: Andy Moreton <andrewjmoreton@gmail.com>
Cc: 33294@debbugs.gnu.org
Subject: bug#33294: xwidget-insert crashes Emacs
Date: Thu, 08 Nov 2018 11:45:28 +0200 [thread overview]
Message-ID: <83zhujc37r.fsf@gnu.org> (raw)
In-Reply-To: <vz1o9b0n9rz.fsf@gmail.com> (message from Andy Moreton on Wed, 07 Nov 2018 16:16:00 +0000)
> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Wed, 07 Nov 2018 16:16:00 +0000
>
> Unrelated to this bug, but a quick look at the code shows that
> xwidget-insert calls make-xwidget, which returns an uninitialized object
> if the type argument is not 'webkit.
Not sure I follow: this part of the code seems to initialize the
object that is returned even if TYPE is not 'webkit':
struct xwidget *xw = allocate_xwidget ();
Lisp_Object val;
xw->type = type;
xw->title = title;
xw->buffer = NILP (buffer) ? Fcurrent_buffer () : Fget_buffer_create (buffer);
xw->height = XFASTINT (height);
xw->width = XFASTINT (width);
xw->kill_without_query = false;
XSETXWIDGET (val, xw);
Vxwidget_list = Fcons (val, Vxwidget_list);
xw->widgetwindow_osr = NULL;
xw->widget_osr = NULL;
xw->plist = Qnil;
next prev parent reply other threads:[~2018-11-08 9:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 21:13 bug#33294: xwidget-insert crashes Emacs Evgeny Zajcev
2018-11-07 4:40 ` Eli Zaretskii
2018-11-07 16:16 ` Andy Moreton
2018-11-08 9:45 ` Eli Zaretskii [this message]
2018-11-08 13:01 ` Andy Moreton
[not found] ` <CAO=W_ZqJZ0APsO1skAs+1vh8KXs+JWR7YAiHNKuWV3VdmDmU8g@mail.gmail.com>
2018-11-08 4:54 ` Eli Zaretskii
2018-11-08 13:44 ` Evgeny Zajcev
2018-11-08 14:49 ` Eli Zaretskii
2018-11-08 16:21 ` Robert Pluim
2018-11-08 18:47 ` Eli Zaretskii
2018-11-08 20:15 ` Stefan Monnier
2018-11-09 7:44 ` Eli Zaretskii
2018-11-09 13:16 ` Robert Pluim
2018-11-09 13:29 ` Stefan Monnier
2018-11-09 13:46 ` Robert Pluim
2018-11-09 14:37 ` Stefan Monnier
2018-11-09 14:57 ` Robert Pluim
2018-11-09 14:56 ` Eli Zaretskii
2018-11-09 16:11 ` Stefan Monnier
2018-11-12 14:44 ` Evgeny Zajcev
2018-11-12 16:11 ` Eli Zaretskii
2018-11-13 11:43 ` Evgeny Zajcev
2018-11-16 8:32 ` Eli Zaretskii
2018-11-24 8:15 ` Eli Zaretskii
2018-11-26 14:02 ` Robert Pluim
2018-11-26 16:27 ` Eli Zaretskii
2018-11-27 7:54 ` Eli Zaretskii
2018-11-27 9:33 ` Robert Pluim
2018-11-27 8:43 ` Robert Pluim
2018-11-27 9:12 ` Eli Zaretskii
2018-11-09 18:09 ` Glenn Morris
2018-11-10 2:23 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zhujc37r.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=33294@debbugs.gnu.org \
--cc=andrewjmoreton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.