all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Ulrich Mueller <ulm@gentoo.org>
Cc: emacs-devel@gnu.org
Subject: Re: No support for ImageMagick 7 in emacs-26
Date: Mon, 26 Nov 2018 19:38:02 +0200	[thread overview]
Message-ID: <83zhtvhh8l.fsf@gnu.org> (raw)
In-Reply-To: <w6glg5gcmqa.fsf@kph.uni-mainz.de> (message from Ulrich Mueller on Mon, 26 Nov 2018 08:38:21 +0100)

> From: Ulrich Mueller <ulm@gentoo.org>
> Cc: emacs-devel@gnu.org
> Date: Mon, 26 Nov 2018 08:38:21 +0100
> 
> > It doesn't seem entirely trivial to me.  ImageMagick caused quitea few
> > problems to Emacs, so at this point I can only accept patches to
> > support v7 on the release branch if the code used by v6.x is
> > completely unchanged.
> 
> Sorry, but where do you see a change that could affect behaviour of
> v6.x? Effectively, the only code change in the consolidated patch is the
> following in image.c:
> 
> -      MagickRealType color_scale = 65535.0 / QuantumRange;
> +      double quantum_range = QuantumRange;
> +      MagickRealType color_scale = 65535.0 / quantum_range;

This is one part that I'd rather not do on the release branch (why is
it needed, anyway?).  The other one is that inclusion of a header file
was moved to a different place for some reason.  (Yes, I'm being
paranoid ;-)

> Also, I noticed that configure will silently disable imagemagick if v6
> is not found. This is o.k. for the default, but when I explicitly
> specify --with-imagemagick, then I would expect it to error out when it
> cannot enable the feature.

Patches to that effect are welcome, but that part should definitely
not go to the release branch.

Thanks.



  reply	other threads:[~2018-11-26 17:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-25  8:26 No support for ImageMagick 7 in emacs-26 Ulrich Mueller
2018-11-25 16:26 ` Eli Zaretskii
2018-11-26  7:38   ` Ulrich Mueller
2018-11-26 17:38     ` Eli Zaretskii [this message]
2018-11-26 22:00       ` Ulrich Mueller
2018-11-26 22:07         ` Andreas Schwab
2018-11-27  5:48         ` Eli Zaretskii
2018-11-27  1:38     ` Paul Eggert
2018-11-27  6:14       ` Eli Zaretskii
2018-11-27 16:35         ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zhtvhh8l.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=ulm@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.