all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#33494: 25.2; vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches
@ 2018-11-24 22:57 Steven De Herdt
  2018-12-08  9:35 ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Steven De Herdt @ 2018-11-24 22:57 UTC (permalink / raw)
  To: 33494

Hello.

In Bzr-Log-View, pressing RET brings up more info about a certain
revision, but this expanded log entry does not honor customized switches
for 'bzr log'.  I hacked vc-bzr-expanded-log-entry to consider these
switches just like vc-bzr-print-log does:

(defun vc-bzr-expanded-log-entry (revision)
  (with-temp-buffer
    (apply 'vc-bzr-command "log" t nil nil
     (append
      (list "--long" (format "-r%s" revision))
      (if (stringp vc-bzr-log-switches)
          (list vc-bzr-log-switches)
        vc-bzr-log-switches)))
    (goto-char (point-min))
    (when (looking-at "^-+\n")
      ;; Indent the expanded log entry.
      (indent-region (match-end 0) (point-max) 2)
      (buffer-substring (match-end 0) (point-max)))))

I don't know a lot of Emacs Lisp, but it does work with 'emacs -q'...

Thanks for you work on Emacs!
-Steven






^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#33494: 25.2; vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches
  2018-11-24 22:57 bug#33494: 25.2; vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches Steven De Herdt
@ 2018-12-08  9:35 ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2018-12-08  9:35 UTC (permalink / raw)
  To: Steven De Herdt; +Cc: 33494-done

> From: Steven De Herdt <steven.deherdt@gmail.com>
> Date: Sat, 24 Nov 2018 23:57:57 +0100
> 
> In Bzr-Log-View, pressing RET brings up more info about a certain
> revision, but this expanded log entry does not honor customized switches
> for 'bzr log'.  I hacked vc-bzr-expanded-log-entry to consider these
> switches just like vc-bzr-print-log does:

Thanks, pushed to the master branch.





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-08  9:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-24 22:57 bug#33494: 25.2; vc-bzr-expanded-log-entry does not honor vc-bzr-log-switches Steven De Herdt
2018-12-08  9:35 ` Eli Zaretskii

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.