From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob Date: Sat, 23 Feb 2019 10:51:28 +0200 Message-ID: <83zhqmq44v.fsf@gnu.org> References: <87d0pcfkjq.fsf@gmail.com> <87mumpgl0v.fsf@gmail.com> <83bm34fccz.fsf@gnu.org> <87mumncy6v.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="86236"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 33975@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 23 09:52:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gxT2Y-000MLt-I3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Feb 2019 09:52:10 +0100 Original-Received: from localhost ([127.0.0.1]:34888 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxT2X-0006tv-Jp for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Feb 2019 03:52:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxT2R-0006to-Pf for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2019 03:52:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gxT2Q-0007t2-Kk for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2019 03:52:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35288) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gxT2Q-0007sg-0Q for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2019 03:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gxT2P-0004n8-Sp for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2019 03:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Feb 2019 08:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33975-submit@debbugs.gnu.org id=B33975.155091189618387 (code B ref 33975); Sat, 23 Feb 2019 08:52:01 +0000 Original-Received: (at 33975) by debbugs.gnu.org; 23 Feb 2019 08:51:36 +0000 Original-Received: from localhost ([127.0.0.1]:48832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxT1z-0004mV-QU for submit@debbugs.gnu.org; Sat, 23 Feb 2019 03:51:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxT1y-0004mJ-F6 for 33975@debbugs.gnu.org; Sat, 23 Feb 2019 03:51:35 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47401) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxT1p-0007cg-Eo; Sat, 23 Feb 2019 03:51:25 -0500 Original-Received: from [176.228.60.248] (port=3094 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gxT1p-0002zk-2g; Sat, 23 Feb 2019 03:51:25 -0500 In-reply-to: <87mumncy6v.fsf@gmail.com> (message from Alex Branham on Fri, 22 Feb 2019 15:26:00 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155678 Archived-At: > From: Alex Branham > Cc: 33975@debbugs.gnu.org > Date: Fri, 22 Feb 2019 15:26:00 -0600 > > > Can you explain how having comint-prompt-read-only interferes with > > interrupt-process in this case? I don't think I understand the > > connection, and neither this bug report nor the ESS issue do, AFAICT. > > Sure thing. `comint-interrupt-subjob' calls `comint-skip-input', which > tries to do this: > > (insert " " (key-description (this-command-keys))) > > Which fails if the text at point is read only. Then shouldn't the change be inside comint-skip-input instead? I mean, the same problem will happen also in all other callers of comint-skip-input, no? (I'm not sure I understand why that function inserts the description of this-command-keys -- is that to insert "C-c C-c" into the buffer? This is not in the doc string, perhaps we should add that.) Thanks.