all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Alex Branham <alex.branham@gmail.com>
Cc: 33975@debbugs.gnu.org
Subject: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob
Date: Sat, 23 Feb 2019 10:51:28 +0200	[thread overview]
Message-ID: <83zhqmq44v.fsf@gnu.org> (raw)
In-Reply-To: <87mumncy6v.fsf@gmail.com> (message from Alex Branham on Fri, 22 Feb 2019 15:26:00 -0600)

> From: Alex Branham <alex.branham@gmail.com>
> Cc: 33975@debbugs.gnu.org
> Date: Fri, 22 Feb 2019 15:26:00 -0600
> 
> > Can you explain how having comint-prompt-read-only interferes with
> > interrupt-process in this case?  I don't think I understand the
> > connection, and neither this bug report nor the ESS issue do, AFAICT.
> 
> Sure thing. `comint-interrupt-subjob' calls `comint-skip-input', which
> tries to do this:
> 
> (insert "  " (key-description (this-command-keys)))
> 
> Which fails if the text at point is read only.

Then shouldn't the change be inside comint-skip-input instead?  I
mean, the same problem will happen also in all other callers of
comint-skip-input, no?

(I'm not sure I understand why that function inserts the description
of this-command-keys -- is that to insert "C-c C-c" into the buffer?
This is not in the doc string, perhaps we should add that.)

Thanks.





  reply	other threads:[~2019-02-23  8:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-04 16:35 bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob Alex Branham
2019-02-21 16:32 ` Alex Branham
2019-02-22  8:37   ` Eli Zaretskii
2019-02-22 21:26     ` Alex Branham
2019-02-23  8:51       ` Eli Zaretskii [this message]
2019-02-23 13:36         ` Alex Branham
2019-02-23 17:01           ` Eli Zaretskii
2019-02-24 14:47             ` Alex Branham
2019-02-25  1:11             ` Alex Branham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zhqmq44v.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=33975@debbugs.gnu.org \
    --cc=alex.branham@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.