From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#34317: 26.1.90; Wrong unbinding order in x_consider_frame_title Date: Sun, 24 Feb 2019 18:08:32 +0200 Message-ID: <83zhqlnp8f.fsf@gnu.org> References: <5C588952.1080706@gmx.at> <5C6BC758.8040105@gmx.at> <83tvguq1q5.fsf@gnu.org> <5C7151FF.5070504@gmx.at> <83mummpi53.fsf@gnu.org> <5C72591D.40301@gmx.at> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="179621"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34317@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 24 17:09:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gxwL3-000kdP-OZ for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Feb 2019 17:09:13 +0100 Original-Received: from localhost ([127.0.0.1]:52936 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxwL2-0007zJ-Lk for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Feb 2019 11:09:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxwKx-0007yy-0j for bug-gnu-emacs@gnu.org; Sun, 24 Feb 2019 11:09:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gxwKw-00007X-55 for bug-gnu-emacs@gnu.org; Sun, 24 Feb 2019 11:09:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36817) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gxwKs-000052-Ky for bug-gnu-emacs@gnu.org; Sun, 24 Feb 2019 11:09:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gxwKs-0002yd-Ej for bug-gnu-emacs@gnu.org; Sun, 24 Feb 2019 11:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Feb 2019 16:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34317 X-GNU-PR-Package: emacs Original-Received: via spool by 34317-submit@debbugs.gnu.org id=B34317.155102451611410 (code B ref 34317); Sun, 24 Feb 2019 16:09:02 +0000 Original-Received: (at 34317) by debbugs.gnu.org; 24 Feb 2019 16:08:36 +0000 Original-Received: from localhost ([127.0.0.1]:50361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxwKR-0002xy-WF for submit@debbugs.gnu.org; Sun, 24 Feb 2019 11:08:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxwKQ-0002xj-1W for 34317@debbugs.gnu.org; Sun, 24 Feb 2019 11:08:34 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42065) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxwKH-00084H-9A; Sun, 24 Feb 2019 11:08:26 -0500 Original-Received: from [176.228.60.248] (port=4121 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gxwKF-0002Dw-KK; Sun, 24 Feb 2019 11:08:24 -0500 In-reply-to: <5C72591D.40301@gmx.at> (message from martin rudalics on Sun, 24 Feb 2019 09:43:09 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155717 Archived-At: > Date: Sun, 24 Feb 2019 09:43:09 +0100 > From: martin rudalics > CC: 34317@debbugs.gnu.org > > * src/xdisp.c (x_consider_frame_title): Bind inhibit-redisplay to > t to avoid resizing back the mini-window as result of considering > the title of other frames. (Bug#24285) > (redisplay_window): No need to bind inhibit-redisplay here. > > > This means that in x_consider_frame_title we now do > > ptrdiff_t count = SPECPDL_INDEX (); > > ... > > record_unwind_protect (unwind_format_mode_line, > format_mode_line_unwind_data > (f, current_buffer, selected_window, false)); > ... > > specbind (Qinhibit_redisplay, Qt); > > Fselect_window (f->selected_window, Qt); > > ... > > unbind_to (count, Qnil); > > where unwind_format_mode_line does > > Fselect_window (old_window, Qt); > > The asymmetry I mentioned is that while binding Qinhibit_redisplay > covers the Fselect_window call in x_consider_frame_title, it does not > cover the Fselect_window in unwind_format_mode_line since that is > performed _after_ the special binding of Qinhibit_redisplay has been > abolished. Which means that we call resize_mini_window for the first > call when the corresponding windows are on different frames but not > for the second. I cannot imagine that was on purpose. But your proposed change fixes that, so I'm unsure why you said it won't work OOTB. What did I miss?