From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 34317@debbugs.gnu.org
Subject: bug#34317: 26.1.90; Wrong unbinding order in x_consider_frame_title
Date: Sun, 24 Feb 2019 18:08:32 +0200 [thread overview]
Message-ID: <83zhqlnp8f.fsf@gnu.org> (raw)
In-Reply-To: <5C72591D.40301@gmx.at> (message from martin rudalics on Sun, 24 Feb 2019 09:43:09 +0100)
> Date: Sun, 24 Feb 2019 09:43:09 +0100
> From: martin rudalics <rudalics@gmx.at>
> CC: 34317@debbugs.gnu.org
>
> * src/xdisp.c (x_consider_frame_title): Bind inhibit-redisplay to
> t to avoid resizing back the mini-window as result of considering
> the title of other frames. (Bug#24285)
> (redisplay_window): No need to bind inhibit-redisplay here.
>
>
> This means that in x_consider_frame_title we now do
>
> ptrdiff_t count = SPECPDL_INDEX ();
>
> ...
>
> record_unwind_protect (unwind_format_mode_line,
> format_mode_line_unwind_data
> (f, current_buffer, selected_window, false));
> ...
>
> specbind (Qinhibit_redisplay, Qt);
>
> Fselect_window (f->selected_window, Qt);
>
> ...
>
> unbind_to (count, Qnil);
>
> where unwind_format_mode_line does
>
> Fselect_window (old_window, Qt);
>
> The asymmetry I mentioned is that while binding Qinhibit_redisplay
> covers the Fselect_window call in x_consider_frame_title, it does not
> cover the Fselect_window in unwind_format_mode_line since that is
> performed _after_ the special binding of Qinhibit_redisplay has been
> abolished. Which means that we call resize_mini_window for the first
> call when the corresponding windows are on different frames but not
> for the second.
I cannot imagine that was on purpose.
But your proposed change fixes that, so I'm unsure why you said it
won't work OOTB. What did I miss?
next prev parent reply other threads:[~2019-02-24 16:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 18:49 bug#34317: 26.1.90; Wrong unbinding order in x_consider_frame_title martin rudalics
2019-02-19 9:07 ` martin rudalics
2019-02-23 9:43 ` Eli Zaretskii
2019-02-23 14:00 ` martin rudalics
2019-02-23 16:46 ` Eli Zaretskii
2019-02-24 8:43 ` martin rudalics
2019-02-24 16:08 ` Eli Zaretskii [this message]
2019-02-24 18:30 ` martin rudalics
2019-02-24 18:57 ` Eli Zaretskii
2019-03-04 10:14 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zhqlnp8f.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=34317@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.