From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: face-remapping-alist can not override internal-border face? Date: Sat, 09 Mar 2019 19:16:36 +0200 Message-ID: <83zhq46k97.fsf@gnu.org> References: <3a1726b0.64ab.1695b90bb85.Coremail.tumashu@163.com> <83wol9ai1f.fsf@gnu.org> <6b96411a.e495.1695e1a9d58.Coremail.tumashu@163.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="47800"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: tumashu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 09 18:17:48 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h2fbX-000CJ5-7Y for ged-emacs-devel@m.gmane.org; Sat, 09 Mar 2019 18:17:47 +0100 Original-Received: from localhost ([127.0.0.1]:33338 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2fbW-0002ja-3i for ged-emacs-devel@m.gmane.org; Sat, 09 Mar 2019 12:17:46 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2fah-0002jK-HM for emacs-devel@gnu.org; Sat, 09 Mar 2019 12:16:56 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:32872) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2fag-00010B-Ru; Sat, 09 Mar 2019 12:16:54 -0500 Original-Received: from [176.228.60.248] (port=1490 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h2fae-0000rj-H9; Sat, 09 Mar 2019 12:16:53 -0500 In-reply-to: <6b96411a.e495.1695e1a9d58.Coremail.tumashu@163.com> (message from tumashu on Sat, 9 Mar 2019 00:19:56 +0800 (CST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233979 Archived-At: > Date: Sat, 9 Mar 2019 00:19:56 +0800 (CST) > From: tumashu > Cc: "emacs-devel@gnu.org" > > Sorry, I do not understand this, does this mean: test is inherited to default face, > so internal-border is remapped to default instead of test? but the below code > seem to not work too: > > (defface test > '((:background "green")) > "Face used by the ivy-posframe." > :group 'ivy-posframe) > > (setq face-remapping-alist '((internal-border . test))) > > (make-frame '((internal-border-width . 100))) You are right. I see that when we draw the border, we don't consult face-remapping-alist. But I'm not sure we should, because face-remapping-alist can be buffer-local (and makes most sense when it's buffer-local), whereas the internal-border face affects the entire frame. So maybe instead tell why you wanted to use face-remapping-alist instead of simply changing the face's attributes?