all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: tumashu <tumashu@163.com>
Cc: emacs-devel@gnu.org
Subject: Re: face-remapping-alist can not override internal-border face?
Date: Sat, 09 Mar 2019 19:16:36 +0200	[thread overview]
Message-ID: <83zhq46k97.fsf@gnu.org> (raw)
In-Reply-To: <6b96411a.e495.1695e1a9d58.Coremail.tumashu@163.com> (message from tumashu on Sat, 9 Mar 2019 00:19:56 +0800 (CST))

> Date: Sat, 9 Mar 2019 00:19:56 +0800 (CST)
> From: tumashu  <tumashu@163.com>
> Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
> 
> Sorry, I do not understand this,  does this mean: test is inherited to default face,
> so internal-border is remapped to default instead of test? but the below code
> seem to not work too:
> 
> (defface test
>   '((:background "green"))
>   "Face used by the ivy-posframe."
>   :group 'ivy-posframe)
> 
> (setq face-remapping-alist '((internal-border . test)))
> 
> (make-frame '((internal-border-width . 100)))

You are right.  I see that when we draw the border, we don't consult
face-remapping-alist.  But I'm not sure we should, because
face-remapping-alist can be buffer-local (and makes most sense when
it's buffer-local), whereas the internal-border face affects the
entire frame.

So maybe instead tell why you wanted to use face-remapping-alist
instead of simply changing the face's attributes?



  parent reply	other threads:[~2019-03-09 17:16 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-08  4:30 face-remapping-alist can not override internal-border face? tumashu
2019-03-08  8:26 ` Eli Zaretskii
2019-03-08 16:19   ` tumashu
2019-03-08 18:52     ` martin rudalics
2019-03-09 14:28       ` tumashu
2019-03-09 14:55         ` Eli Zaretskii
2019-03-10  0:35           ` tumashu
2019-03-10  3:36             ` Eli Zaretskii
2019-03-10  8:47               ` martin rudalics
2019-03-10 10:22                 ` tumashu
2019-03-10 10:28                   ` tumashu
2019-03-10 13:00                   ` Eli Zaretskii
2019-03-10 13:16                     ` tumashu
2019-03-10 13:44                       ` Eli Zaretskii
2019-03-11 13:32                         ` tumashu
2019-03-11 15:11                           ` Eli Zaretskii
2019-03-10 12:45                 ` Eli Zaretskii
2019-03-10 12:39             ` Eli Zaretskii
2019-03-10 13:04               ` tumashu
2019-03-10 13:41                 ` Eli Zaretskii
2019-03-10  8:45         ` martin rudalics
2019-03-09 17:16     ` Eli Zaretskii [this message]
2019-03-09 17:51       ` Eli Zaretskii
2019-03-10 10:14       ` tumashu
2019-03-10 12:47         ` Eli Zaretskii
2019-03-10 13:35           ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zhq46k97.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=tumashu@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.