From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH v2] min_cols/rows is always 0, remove noop actions Date: Sat, 06 Apr 2019 10:09:18 +0300 Message-ID: <83zhp3a9up.fsf@gnu.org> References: <87ef6lic84.fsf@gmail.com> <20190402002327.28219-1-Hi-Angel@yandex.ru> <1554502718.25876.0@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1251 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="27211"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35062@debbugs.gnu.org To: Konstantin Kharlamov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 06 09:18:55 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hCfbK-0006q5-HU for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Apr 2019 09:18:54 +0200 Original-Received: from localhost ([127.0.0.1]:51637 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCfbJ-0007Y0-Dr for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Apr 2019 03:18:53 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36571) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCfb1-0007QT-6b for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 03:18:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hCfSk-0001tG-GQ for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 03:10:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32957) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hCfSk-0001sq-3R for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 03:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hCfSj-0003RD-Pg for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2019 03:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Apr 2019 07:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.155453458013180 (code B ref 35062); Sat, 06 Apr 2019 07:10:01 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 6 Apr 2019 07:09:40 +0000 Original-Received: from localhost ([127.0.0.1]:46501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCfSO-0003QV-DB for submit@debbugs.gnu.org; Sat, 06 Apr 2019 03:09:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hCfSM-0003QH-0T for 35062@debbugs.gnu.org; Sat, 06 Apr 2019 03:09:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hCfSE-0001Xp-Rc; Sat, 06 Apr 2019 03:09:32 -0400 Original-Received: from [176.228.60.248] (port=2485 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hCfSD-0001kA-U7; Sat, 06 Apr 2019 03:09:30 -0400 In-reply-to: <1554502718.25876.0@yandex.ru> (message from Konstantin Kharlamov on Sat, 06 Apr 2019 01:18:38 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157250 Archived-At: > Date: Sat, 06 Apr 2019 01:18:38 +0300 > From: Konstantin Kharlamov > Cc: 35062@debbugs.gnu.org > > >> * src/gtkutil.c: > >> remove "always false" comparison > >> remove multiplication by zero, it's a noop anyway > >> remove min_cols and min_rows as it's now unused > >> > >> Fixes LGTM warnings: > >> * Comparison is always false because min_cols <= 0. > >> * Comparison is always false because min_rows <= 0. > >> --- > >> v2: remove the min_rows/min_cols whatsoever > > > > Thanks, pushed. Please in the future write the commit log messages in > > the ChangeLog-like style, see CONTRIBUTE for the details. I did that > > this time, you can look at what I pushed to see an example of that > > style in action. > > Thanks, so, I'm looking right now to modify the rest of series and > resend it here, and… I think I miss something: the only difference of > my commit from CONTRIBUTE file is that I forgot to list the functions > changed. That's right. And also the lack of the bug number, see below. > I think I misunderstand something, because you completely rewrote the > commit messages compared to mine. Titles now are more vague, and for > some reason you removed a note that one of patches fixes warnings in > the code. That's just my personal preferences of style, as there's always a judgment call regarding the description of the changes. We don't have to agree about that, and if your log message was in the right format, I probably wouldn't have bothered changing their text. I can explain my preference: your text described in a very detailed form something that was acutely visible from the diffs themselves, whereas my text only describes the motivation, leaving the rest to the diffs which speak for themselves. The part about LGTM warnings didn't seem important enough to me: LGTM is not a compiler, and without a reference to what it is, the text is a small riddle in itself. More importantly, I don't think we need any justification for removing variables initialized to zero and never changed. Again, these are my personal preferences, not something we require from each contributor. So if you disagree, you can keep your style, and only adjust the form. > And then you also added "Bug#35062", even though there's no > bug (the report existence is incidental, it's because bugtracker is > used to track patches in Emacs. References to bug numbers should always be in the log message, because that allows an easy way of reading relevant discussions recorded by the bug tracker. This _is_ in CONTRIBUTE, btw. > But writing "Bug" will only confuse readers — there's no bug). "Bug" here doesn't mean a literal bug, it means an issue recorded by the bug tracker. Thanks.