Re: master 41bf865: Clean up and simplify image-type setup

Re: master 41bf865: Clean up and simplify image-type setup

[Andy Moreton]

On Fri 17 May 2019, Paul Eggert wrote:

> branch: master
> commit 41bf865329bbc2411203e9a90bc8dfd93ed5ef31
> Author: Paul Eggert <eggert@cs.ucla.edu>
> Commit: Paul Eggert <eggert@cs.ucla.edu>
>
>     Clean up and simplify image-type setup
>     
>     This also fixes an unlikely hang involving a circular image
>     description.

This appears to break image handling on Windows for image formats that
use dynamically loaded DLLs (png,gif,tiff,svg,xpm). Visiting an image
file from dired results in:

    Cannot display image: (Invalid image specification)

The image buffer should have an image spec in the `display' (and
possibly `intangible') text properties at (point-min), but this is
missing.

Images work properly for emacs built from the previous commit on master.

    AndyM

Re: master 41bf865: Clean up and simplify image-type setup

[Eli Zaretskii]

> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Sat, 18 May 2019 14:12:45 +0100
> 
> On Fri 17 May 2019, Paul Eggert wrote:
> 
> > branch: master
> > commit 41bf865329bbc2411203e9a90bc8dfd93ed5ef31
> > Author: Paul Eggert <eggert@cs.ucla.edu>
> > Commit: Paul Eggert <eggert@cs.ucla.edu>
> >
> >     Clean up and simplify image-type setup
> >     
> >     This also fixes an unlikely hang involving a circular image
> >     description.
> 
> This appears to break image handling on Windows for image formats that
> use dynamically loaded DLLs (png,gif,tiff,svg,xpm). Visiting an image
> file from dired results in:
> 
>     Cannot display image: (Invalid image specification)

Thanks, should be fixed now.

> The image buffer should have an image spec in the `display' (and
> possibly `intangible') text properties at (point-min), but this is
> missing.

The problem was with the code which probed whether a given image type
was already loaded.

Re: master 41bf865: Clean up and simplify image-type setup

[Andy Moreton]

On Sat 18 May 2019, Eli Zaretskii wrote:

>> From: Andy Moreton <andrewjmoreton@gmail.com>
>> Date: Sat, 18 May 2019 14:12:45 +0100
>> 
>> On Fri 17 May 2019, Paul Eggert wrote:
>> 
>> > branch: master
>> > commit 41bf865329bbc2411203e9a90bc8dfd93ed5ef31
>> > Author: Paul Eggert <eggert@cs.ucla.edu>
>> > Commit: Paul Eggert <eggert@cs.ucla.edu>
>> >
>> >     Clean up and simplify image-type setup
>> >     
>> >     This also fixes an unlikely hang involving a circular image
>> >     description.
>> 
>> This appears to break image handling on Windows for image formats that
>> use dynamically loaded DLLs (png,gif,tiff,svg,xpm). Visiting an image
>> file from dired results in:
>> 
>>     Cannot display image: (Invalid image specification)
>
> Thanks, should be fixed now.

Thanks Eli, confirmed fixed.

    AndyM