From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35916: [PATCH] checkdoc fixes in bookmark.el Date: Sat, 08 Jun 2019 11:37:42 +0300 Message-ID: <83zhmso4kp.fsf@gnu.org> References: <3d7f02e2-c064-4da4-b6e0-e7b52d0d357d@default> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="4036"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35916@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 08 10:38:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hZWrZ-0000sg-SB for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Jun 2019 10:38:09 +0200 Original-Received: from localhost ([::1]:56280 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZWrY-0006de-Bf for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Jun 2019 04:38:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36120) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZWrT-0006dY-AN for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2019 04:38:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZWrS-0003YF-FA for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2019 04:38:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39280) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hZWrS-0003Y5-AU for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2019 04:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hZWrS-0006Ne-7b for bug-gnu-emacs@gnu.org; Sat, 08 Jun 2019 04:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Jun 2019 08:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35916 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35916-submit@debbugs.gnu.org id=B35916.155998307724515 (code B ref 35916); Sat, 08 Jun 2019 08:38:02 +0000 Original-Received: (at 35916) by debbugs.gnu.org; 8 Jun 2019 08:37:57 +0000 Original-Received: from localhost ([127.0.0.1]:52824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZWrN-0006NL-0a for submit@debbugs.gnu.org; Sat, 08 Jun 2019 04:37:57 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZWrL-0006N8-Ms for 35916@debbugs.gnu.org; Sat, 08 Jun 2019 04:37:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38725) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hZWrG-0003Rw-H9; Sat, 08 Jun 2019 04:37:50 -0400 Original-Received: from [176.228.60.248] (port=2676 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hZWrF-00081c-Aq; Sat, 08 Jun 2019 04:37:49 -0400 In-reply-to: (message from Stefan Kangas on Thu, 30 May 2019 19:53:58 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160234 Archived-At: > From: Stefan Kangas > Date: Thu, 30 May 2019 19:53:58 +0200 > Cc: 35916@debbugs.gnu.org > > Please find attached an updated version of the patch with an improved commit > message. Thanks, this is OK, with one comment: > (defun bookmark-bmenu-other-window-with-mouse (event) > - "Select bookmark at the mouse pointer in other window, leaving bookmark menu visible." > + "Select bookmark at the mouse pointer in other window. > +Move point to the position of EVENT, and leave bookmark menu > +visible." The first line of the doc string should mention the arguments, in this case EVENT. Could you please rework this hunk and resubmit the patch?