From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 35916@debbugs.gnu.org
Subject: bug#35916: [PATCH] checkdoc fixes in bookmark.el
Date: Sat, 08 Jun 2019 11:37:42 +0300 [thread overview]
Message-ID: <83zhmso4kp.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkm=ByNoFjwBt=3it-FLig0x-O_9ZvgZkPHiAMBLZo28DQQ@mail.gmail.com> (message from Stefan Kangas on Thu, 30 May 2019 19:53:58 +0200)
> From: Stefan Kangas <stefan@marxist.se>
> Date: Thu, 30 May 2019 19:53:58 +0200
> Cc: 35916@debbugs.gnu.org
>
> Please find attached an updated version of the patch with an improved commit
> message.
Thanks, this is OK, with one comment:
> (defun bookmark-bmenu-other-window-with-mouse (event)
> - "Select bookmark at the mouse pointer in other window, leaving bookmark menu visible."
> + "Select bookmark at the mouse pointer in other window.
> +Move point to the position of EVENT, and leave bookmark menu
> +visible."
The first line of the doc string should mention the arguments, in this
case EVENT. Could you please rework this hunk and resubmit the patch?
next prev parent reply other threads:[~2019-06-08 8:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-26 10:59 bug#35916: [PATCH] checkdoc fixes in bookmark.el Stefan Kangas
2019-05-27 3:52 ` Drew Adams
2019-05-27 21:36 ` Stefan Kangas
2019-05-30 17:53 ` Stefan Kangas
2019-06-08 8:37 ` Eli Zaretskii [this message]
2019-06-08 17:22 ` Stefan Kangas
2019-06-09 6:51 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zhmso4kp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=35916@debbugs.gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.