From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36452: [PATCH] Add tests for bookmark.el Date: Tue, 02 Jul 2019 19:41:00 +0300 Message-ID: <83zhlwcrtv.fsf@gnu.org> References: Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="103767"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36452@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 02 20:31:05 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hiNYR-000QWM-DY for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jul 2019 20:30:59 +0200 Original-Received: from localhost ([::1]:56148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiNXN-00017S-WA for geb-bug-gnu-emacs@m.gmane.org; Tue, 02 Jul 2019 14:29:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51615) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hiLr1-0000sR-Lh for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 12:42:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hiLr0-0006xT-Nu for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 12:42:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38963) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hiLr0-0006wn-Ie for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 12:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hiLr0-0005qa-Cb for bug-gnu-emacs@gnu.org; Tue, 02 Jul 2019 12:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Jul 2019 16:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36452-submit@debbugs.gnu.org id=B36452.156208568522434 (code B ref 36452); Tue, 02 Jul 2019 16:42:02 +0000 Original-Received: (at 36452) by debbugs.gnu.org; 2 Jul 2019 16:41:25 +0000 Original-Received: from localhost ([127.0.0.1]:47784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiLqP-0005pm-Bq for submit@debbugs.gnu.org; Tue, 02 Jul 2019 12:41:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hiLqN-0005pa-G1 for 36452@debbugs.gnu.org; Tue, 02 Jul 2019 12:41:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52177) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hiLqE-0004uX-Pc; Tue, 02 Jul 2019 12:41:18 -0400 Original-Received: from [176.228.60.248] (port=4692 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hiLqE-0007tp-9D; Tue, 02 Jul 2019 12:41:14 -0400 In-reply-to: (message from Stefan Kangas on Mon, 1 Jul 2019 01:32:56 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161970 Archived-At: > From: Stefan Kangas > Date: Mon, 1 Jul 2019 01:32:56 +0200 > > I've written tests for bookmark.el. Please see the attached patch. Thanks. Can you tell the approximate coverage of bookmark functionality by these tests? One particular aspect of the bookmarks that I'd like to see tested is non-ASCII bookmark names and annotations. The code includes some slightly involved logic for determining how to encode the info on disk, so I wonder how well does that work in practice. > --- /dev/null > +++ b/test/lisp/bookmark-resources/test.bmk > @@ -0,0 +1,10 @@ > +;;;; Emacs Bookmark Format Version 1 ;;;; -*- coding: utf-8-emacs -*- > +;;; This format is meant to be slightly human-readable; > +;;; nevertheless, you probably don't want to edit it. > +;;; -*- End Of Bookmark File Format Version Stamp -*- > +(("name" > + (filename . "/some/file") > + (front-context-string . "abc") > + (rear-context-string . "def") > + (position . 3)) > +) > \ No newline at end of file Is this lack of newline intentional?