From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode Date: Fri, 02 Aug 2019 12:10:10 +0300 Message-ID: <83zhksexvx.fsf@gnu.org> References: <875znjntfe.fsf@mail.linkov.net> <83mugvhr66.fsf@gnu.org> <871ry6rksu.fsf@mail.linkov.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="243091"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36861@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 02 11:11:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1htTae-00117C-Ku for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Aug 2019 11:11:08 +0200 Original-Received: from localhost ([::1]:32870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htTad-0005dq-AJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Aug 2019 05:11:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49474) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1htTaZ-0005dc-1T for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2019 05:11:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1htTaY-0005sG-1R for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2019 05:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46952) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1htTaX-0005sB-UJ for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2019 05:11:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1htTaX-00087d-N3 for bug-gnu-emacs@gnu.org; Fri, 02 Aug 2019 05:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Aug 2019 09:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36861 X-GNU-PR-Package: emacs Original-Received: via spool by 36861-submit@debbugs.gnu.org id=B36861.156473703031183 (code B ref 36861); Fri, 02 Aug 2019 09:11:01 +0000 Original-Received: (at 36861) by debbugs.gnu.org; 2 Aug 2019 09:10:30 +0000 Original-Received: from localhost ([127.0.0.1]:55773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htTa0-00086s-Ff for submit@debbugs.gnu.org; Fri, 02 Aug 2019 05:10:29 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1htTZz-00086f-4m for 36861@debbugs.gnu.org; Fri, 02 Aug 2019 05:10:27 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:53249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1htTZq-0005WM-Dj; Fri, 02 Aug 2019 05:10:20 -0400 Original-Received: from [176.228.60.248] (port=3560 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1htTZo-0001wL-3Z; Fri, 02 Aug 2019 05:10:16 -0400 In-reply-to: <871ry6rksu.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 31 Jul 2019 23:49:53 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164307 Archived-At: > From: Juri Linkov > Cc: 36861@debbugs.gnu.org > Date: Wed, 31 Jul 2019 23:49:53 +0300 > > >> (log-edit-mode . ((log-edit-font-lock-gnu-style . t) > >> - (log-edit-setup-add-author . t))) > >> + (log-edit-setup-add-author . t) > >> + (display-fill-column-indicator-column . 78) > >> + (eval . (display-fill-column-indicator-mode)))) > > > > This will cause an annoying message and prompt when editing Emacs > > sources with an Emacs which doesn't yet have > > display-fill-column-indicator-mode, right? Can we avoid that? I > > routinely need to work on the latest sources with an older Emacs. > > Shouldn't local-variables functions ignore undefined variables and commands? > Probably not, since such change won't help for older versions. Right, and we cannot summarily allow any variables a given Emacs doesn't know about, that'd we unsafe. > Then one way is to put such lines to the init file > to avoid typing `y' to confirm local variables > while using emacs-26 to commit emacs-27 changes: Rather than requiring users of older Emacsen to change their init files in such strange ways, which will/might be a problem when they upgrade to Emacs 27, why not expect users who want the early detection of long lines to turn on display-fill-column-indicator-mode in their init files? IOW, the solution that requires changes to one's init files goes both ways. > And for emacs-27 and future versions this patch is required as well: > > diff --git a/lisp/cus-start.el b/lisp/cus-start.el > index e1d0bce2ad..036674ef14 100644 > --- a/lisp/cus-start.el > +++ b/lisp/cus-start.el > @@ -650,7 +650,7 @@ minibuffer-prompt-properties--setter > "26.1") > > (display-fill-column-indicator display-fill-column-indicator > - boolean "27.1") > + boolean "27.1" :safe booleanp) > (display-fill-column-indicator-column display-fill-column-indicator > (choice > (const :tag "Use fill-column variable" > @@ -659,9 +659,9 @@ minibuffer-prompt-properties--setter > :value 70 > :format "%v") > integer) > - "27.1") > + "27.1" :safe (lambda (value) (or (booleanp value) (integerp value)))) > (display-fill-column-indicator-character display-fill-column-indicator > - character "27.1") > + character "27.1" :safe characterp) > ;; xfaces.c > (scalable-fonts-allowed display boolean "22.1") > ;; xfns.c This is fine with me, but I don't think we should make the change in .dir-locals.el. Thanks.