From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 37592@debbugs.gnu.org
Subject: bug#37592: Using tabs in EWW
Date: Thu, 03 Oct 2019 05:44:27 +0300 [thread overview]
Message-ID: <83zhii7dkk.fsf@gnu.org> (raw)
In-Reply-To: <87r23uga96.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 02 Oct 2019 23:31:17 +0300)
> From: Juri Linkov <juri@linkov.net>
> Date: Wed, 02 Oct 2019 23:31:17 +0300
>
> Like <C-mouse-1> in web browsers opens links in a new tab,
> the attached patch does the same for EWW.
>
> The change that implements support for tabs in EWW is just 3 lines:
>
> (when eww-browse-url-new-window-is-tab
> (let ((tab-bar-new-tab-choice t))
> (tab-new)))
>
> Everything else is replicating the existing code:
>
> 1. A new defcustom eww-browse-url-new-window-is-tab is a copy
> of existing browse-url-firefox-new-window-is-tab
>
> 2. The docstring for eww-browse-url is copied from browse-url-firefox
>
> 3. The code for shr-browse-url is copied from browse-url-at-point
Instead of adding another defcustom, how about doing this by default
if tab-bar-mode is enabled?
next prev parent reply other threads:[~2019-10-03 2:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 20:31 bug#37592: Using tabs in EWW Juri Linkov
2019-10-02 21:20 ` Juri Linkov
2019-10-03 2:44 ` Eli Zaretskii [this message]
2019-10-03 22:39 ` Juri Linkov
2019-10-04 7:34 ` Eli Zaretskii
2019-10-05 22:35 ` Juri Linkov
2019-10-06 17:22 ` Eli Zaretskii
2019-10-06 20:06 ` Lars Ingebrigtsen
2019-10-06 21:08 ` Juri Linkov
2019-10-19 22:40 ` Juri Linkov
2019-10-03 14:20 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zhii7dkk.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=37592@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.