From: Eli Zaretskii <eliz@gnu.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 37641@debbugs.gnu.org
Subject: bug#37641: major/minor tick faces bleed into empty lines at the end of buffer
Date: Wed, 09 Oct 2019 13:22:47 +0300 [thread overview]
Message-ID: <83zhiausjs.fsf@gnu.org> (raw)
In-Reply-To: <CAAeL0STBn3rYzTvjJfCfVtieHSkJaG3tWgF-L3Bhap10a5FWow@mail.gmail.com> (message from Juanma Barranquero on Tue, 8 Oct 2019 12:47:22 +0200)
> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Tue, 8 Oct 2019 12:47:22 +0200
> Cc: 37641@debbugs.gnu.org
>
> Turns out there's a difference after all. See the attached images. If you move the
> cursor past the EOB, with the beyond_zv check the line is drawn with the line-number
> face, not the line-number-current-line face. If we check with it->what != IT_EOB,
> then the line-number-current-line face is used.
>
> I think the right thing to do, when dealing with the "phantom line" just past the EOB,
> is to:
> - Use line-number-current-line, if the cursor is there.
> - Use the line-number face, and not the tick faces, if the cursor is not, regardless
> of whether this phantom line would be a tick line or not if it were used.
Agreed.
> So there's a patch that checks for tick faces with beyond_zv, for the current line
> face with it->what, and that moves all face setting for line numbers entirely out of
> the loop.
LGTM, thanks.
next prev parent reply other threads:[~2019-10-09 10:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 1:04 bug#37641: major/minor tick faces bleed into empty lines at the end of buffer Juanma Barranquero
2019-10-07 3:42 ` Juanma Barranquero
2019-10-07 16:17 ` Eli Zaretskii
2019-10-08 2:38 ` Juanma Barranquero
2019-10-08 4:23 ` Juanma Barranquero
2019-10-08 8:51 ` Eli Zaretskii
2019-10-08 8:49 ` Eli Zaretskii
2019-10-08 9:37 ` Juanma Barranquero
2019-10-08 10:47 ` Juanma Barranquero
2019-10-09 10:22 ` Eli Zaretskii [this message]
2019-10-09 10:39 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zhiausjs.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=37641@debbugs.gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.