From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Thu, 05 Dec 2019 20:02:49 +0200 Message-ID: <83zhg6hcqe.fsf@gnu.org> References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83k18bg55h.fsf@gnu.org> <20191107154136.nqujd5olhudr5nvr@Ergus> <372f47e9-74fe-e3cc-8061-ebfbe629392e@gmx.at> <20191107215732.ojv3jjbyaxh6lgcj@Ergus> <9a3e72e8-6ac4-70e0-11fe-0f0d84b41932@gmx.at> <87v9quafc9.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="114704"; mail-complaints-to="usenet@blaine.gmane.org" Cc: spacibba@aol.com, jonas@bernoul.li, 37774@debbugs.gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 05 19:16:32 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1icvg0-000Tjw-ME for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Dec 2019 19:16:32 +0100 Original-Received: from localhost ([::1]:59234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icvfz-0004yA-CL for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Dec 2019 13:16:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42164) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icvTv-0001KM-Rv for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 13:04:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icvTu-0006SX-Ht for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 13:04:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39180) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1icvTu-0006RU-CT for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 13:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1icvTu-0007US-8K for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 13:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Dec 2019 18:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157556898728727 (code B ref 37774); Thu, 05 Dec 2019 18:04:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 5 Dec 2019 18:03:07 +0000 Original-Received: from localhost ([127.0.0.1]:45153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icvT1-0007TG-5a for submit@debbugs.gnu.org; Thu, 05 Dec 2019 13:03:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1icvSx-0007Sl-GZ for 37774@debbugs.gnu.org; Thu, 05 Dec 2019 13:03:04 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44371) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1icvSr-0003U3-EE; Thu, 05 Dec 2019 13:02:57 -0500 Original-Received: from [176.228.60.248] (port=2470 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1icvSo-0006TT-UK; Thu, 05 Dec 2019 13:02:55 -0500 In-reply-to: <87v9quafc9.fsf@gmail.com> (message from =?UTF-8?Q?K=C3=A9vin?= Le Gouguec on Thu, 05 Dec 2019 17:48:22 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172920 Archived-At: > From: Kévin Le Gouguec > Cc: Ergus , Eli Zaretskii , > jonas@bernoul.li, 37774@debbugs.gnu.org > Date: Thu, 05 Dec 2019 17:48:22 +0100 > > I think there might have been a regression since this commit: in-between > 1c29ba0340 (2019-11-17) and 21790e5473 (2019-12-05), something caused > the backgrounds to no longer extend for faces with unspecified :extend > inheriting faces with :extend t. Right. > (custom-theme-set-faces > 'extend-inherit > '(default ((t (:background "black" :foreground "gainsboro")))) > '(highlight ((t (:background "gray10")))) > '(diff-added ((t (:background "#12222f" :extend t)))) > '(diff-removed ((t (:background "#2f1e00" :extend t)))) > '(diff-refine-added ((t (:background "#1b3347")))) > '(diff-refine-removed ((t (:background "#472e00")))) > '(ediff-current-diff-A ((t (:inherit (diff-removed))))) Why are you using values for :inherit that are lists of one element? Why not just ":inherit FACE"? But yes, this is a bug: the value of :inherit can legitimately be a list. Should be fixed now, thanks.