From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 7e387c9: * lisp/man.el (Man-width-max): New defcustom (bug#32536, bug#9385) Date: Sun, 08 Dec 2019 20:03:59 +0200 Message-ID: <83zhg2d78w.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="162861"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: juri@jurta.org (Juri Linkov) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 08 19:05:18 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ie0vl-000gDJ-Pd for ged-emacs-devel@m.gmane.org; Sun, 08 Dec 2019 19:05:17 +0100 Original-Received: from localhost ([::1]:60542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ie0vk-0000zZ-0H for ged-emacs-devel@m.gmane.org; Sun, 08 Dec 2019 13:05:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38256) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ie0uq-0000y8-Hh for emacs-devel@gnu.org; Sun, 08 Dec 2019 13:04:21 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ie0uo-0000vf-Cb; Sun, 08 Dec 2019 13:04:18 -0500 Original-Received: from [176.228.60.248] (port=3318 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ie0un-0002zz-Nn; Sun, 08 Dec 2019 13:04:18 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243236 Archived-At: > +(defun Man-columns () > + (let ((width (cond > + ((and (integerp Man-width) (> Man-width 0)) > + Man-width) > + (Man-width > + (let ((window (get-buffer-window nil t))) > + (frame-width (and window (window-frame window))))) > + (t > + (window-width (get-buffer-window nil t)))))) Bother: both frame-width and window-width return values in units of the canonical character width, which will not change if the default face is remapped. And you are using the value to set the COLUMNS environment variable, so you could get too wide lines, which will not fit within the window. P.S. And please do not "optimize" the log messages the way you did in this commit: it will make the generated ChangeLog entry look wrong. Please only use the ChangeLog-style text in the header line of the log entry if it is the entire text; otherwise please come up with some summary there, and leave the ChangeLog-style text in its original form, without an empty line in between. TIA.