From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 40576@debbugs.gnu.org, giorgian@gmail.com
Subject: bug#40576: call-process-region does not accept nil as first argument
Date: Sun, 12 Apr 2020 19:21:06 +0300 [thread overview]
Message-ID: <83zhbgk74d.fsf@gnu.org> (raw)
In-Reply-To: <CAArVCkSnSWVrBU536b_+JksEU8XMyWqBLHcMWGT_gLUJ_DxrfA@mail.gmail.com> (message from Philipp Stephani on Sun, 12 Apr 2020 18:01:40 +0200)
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sun, 12 Apr 2020 18:01:40 +0200
> Cc: 40576@debbugs.gnu.org
>
> > According to the documentation of call-process-region,
> > If START is nil, that means to use the entire buffer contents; END is
> > ignored.
> >
> > But when I run:
> > (call-process-region nil nil "/bin/cat" t (current-buffer))
> > I get:
> > Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p nil)
> > call-process-region(nil nil "/bin/cat" t #<buffer *scratch*>)
> > eval((call-process-region nil nil "/bin/cat" t (current-buffer)) nil)
> > elisp--eval-last-sexp(t)
> > eval-last-sexp(t)
> > eval-print-last-sexp(nil)
> > funcall-interactively(eval-print-last-sexp nil)
> > call-interactively(eval-print-last-sexp nil nil)
> > command-execute(eval-print-last-sexp)
> >
> > If, instead, I run:
> > (call-process-region (point-min) (point-max) "/bin/cat" t (current-buffer))
> >
> > It works.
> >
> > Am I interpreting the documentation wrong?
>
> Nope, looks like a genuine bug (that happens only if DELETE is non-nil).
Right. But there's more here than meets the eye, because the change
after which we started advertising the special meaning of nil for
START exposed a problem: write_region, called from create_temp_file,
has special meaning for START = nil: it widens the buffer and writes
the entire buffer contents to the temp file. Which isn't right when
write_region is called from call-process-region, as it allows access
to inaccessible portion of the buffer, something we shouldn't do.
So I propose the patch below to fix this bug on the master branch.
Any objections?
diff --git a/src/callproc.c b/src/callproc.c
index 8883415..7f495a3 100644
--- a/src/callproc.c
+++ b/src/callproc.c
@@ -1039,8 +1039,8 @@ DEFUN ("call-process-region", Fcall_process_region, Scall_process_region,
START and END are normally buffer positions specifying the part of the
buffer to send to the process.
-If START is nil, that means to use the entire buffer contents; END is
-ignored.
+If START is nil, that means to use the entire accessible part of the
+buffer; END is ignored.
If START is a string, then send that string to the process
instead of any buffer contents; END is ignored.
The remaining arguments are optional.
@@ -1087,6 +1087,14 @@ t (mix it with ordinary output), or a file name string.
empty_input = XFIXNUM (start) == XFIXNUM (end);
}
+ if (NILP (start))
+ {
+ XSETFASTINT (start, BEGV);
+ args[0] = start;
+ XSETFASTINT (end, ZV);
+ args[1] = end;
+ }
+
if (!empty_input)
fd = create_temp_file (nargs, args, &infile);
else
next prev parent reply other threads:[~2020-04-12 16:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-12 14:25 bug#40576: call-process-region does not accept nil as first argument Pietro Giorgianni
2020-04-12 16:01 ` Philipp Stephani
2020-04-12 16:21 ` Eli Zaretskii [this message]
2020-04-12 16:44 ` Philipp Stephani
2020-04-12 17:07 ` Eli Zaretskii
2020-04-12 17:09 ` Philipp Stephani
2020-04-12 17:07 ` Philipp Stephani
2020-04-12 17:24 ` Eli Zaretskii
2020-04-12 17:37 ` Philipp Stephani
2020-04-12 18:29 ` Eli Zaretskii
2020-04-12 17:07 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zhbgk74d.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=40576@debbugs.gnu.org \
--cc=giorgian@gmail.com \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.