From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Compiling emacs-27.0.91 on macOS Catalina Date: Fri, 15 May 2020 14:26:50 +0300 Message-ID: <83zha91ls5.fsf@gnu.org> References: <20200512221907.GB50065@breton.holly.idiocy.org> <83sgg47evg.fsf@gnu.org> <20200514192432.GA50681@breton.holly.idiocy.org> <83d0754tqs.fsf@gnu.org> <20200515062558.GA52382@breton.holly.idiocy.org> <83lflt34ja.fsf@gnu.org> <20200515104600.GA52992@breton.holly.idiocy.org> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="48388"; mail-complaints-to="usenet@ciao.gmane.io" Cc: paranda@it.uc3m.es, emacs-devel@gnu.org To: Alan Third Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 15 13:27:37 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jZYV6-000CPi-8g for ged-emacs-devel@m.gmane-mx.org; Fri, 15 May 2020 13:27:36 +0200 Original-Received: from localhost ([::1]:44374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZYV5-0001E1-9k for ged-emacs-devel@m.gmane-mx.org; Fri, 15 May 2020 07:27:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59008) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jZYUb-0000iM-E9 for emacs-devel@gnu.org; Fri, 15 May 2020 07:27:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36010) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jZYUa-0005GA-4L; Fri, 15 May 2020 07:27:04 -0400 Original-Received: from [176.228.60.248] (port=2065 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jZYUZ-0006bX-7B; Fri, 15 May 2020 07:27:03 -0400 In-Reply-To: <20200515104600.GA52992@breton.holly.idiocy.org> (message from Alan Third on Fri, 15 May 2020 11:46:00 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250382 Archived-At: > Date: Fri, 15 May 2020 11:46:00 +0100 > From: Alan Third > Cc: paranda@it.uc3m.es, emacs-devel@gnu.org > > > I don't think I understand the effect of this change yet, so I cannot > > answer the question. How will this prevent the problem? > > The color file is simply a native version of etc/rgb.txt. It contains > colour values and their names. > > I'm not really sure why we save it, to be honest. > > On first run Emacs detects there is no color file (cl == nil in the > code) and generates it from rgb.txt. > > Since we're unable to detect directly if loading the color file has > thrown an error my change checks whether there are less colors loaded > than there are in rgb.txt. If there are less then it will regenerate > the file. > > It's not great, rgb.txt could change, but I assume at this stage that > that's unlikely or rare. Thanks. If you think this is safe enough to have it in Emacs 27, please go ahead and push to the release branch. Otherwise, let's have a PROBLEMS entry on emacs-27 and this fix on master.