From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#42397: [PATCH 06/14] * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Fix indentation. Date: Thu, 16 Jul 2020 22:25:19 +0300 Message-ID: <83zh7zjm8w.fsf@gnu.org> References: <20200716145456.17531-1-jonas@bernoul.li> <20200716145456.17531-2-jonas@bernoul.li> <20200716145456.17531-3-jonas@bernoul.li> <20200716145456.17531-4-jonas@bernoul.li> <20200716145456.17531-5-jonas@bernoul.li> <20200716145456.17531-6-jonas@bernoul.li> <83d04vlbu8.fsf@gnu.org> <87mu3zpfez.fsf@bernoul.li> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23316"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42397@debbugs.gnu.org To: Jonas Bernoulli Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 16 21:26:19 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jw9WM-0005y0-Fl for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Jul 2020 21:26:18 +0200 Original-Received: from localhost ([::1]:52120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jw9WL-0002UP-9e for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Jul 2020 15:26:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jw9W6-0002S4-CK for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 15:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44489) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jw9W6-0008Eh-1h for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 15:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jw9W5-0005lg-Rz for bug-gnu-emacs@gnu.org; Thu, 16 Jul 2020 15:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Jul 2020 19:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42397 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 42397-submit@debbugs.gnu.org id=B42397.159492754222142 (code B ref 42397); Thu, 16 Jul 2020 19:26:01 +0000 Original-Received: (at 42397) by debbugs.gnu.org; 16 Jul 2020 19:25:42 +0000 Original-Received: from localhost ([127.0.0.1]:56035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw9Vl-0005l4-NX for submit@debbugs.gnu.org; Thu, 16 Jul 2020 15:25:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jw9Vi-0005kq-TD for 42397@debbugs.gnu.org; Thu, 16 Jul 2020 15:25:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54084) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jw9Vc-00089o-SP; Thu, 16 Jul 2020 15:25:32 -0400 Original-Received: from [176.228.60.248] (port=1414 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jw9Vc-0006dj-07; Thu, 16 Jul 2020 15:25:32 -0400 In-Reply-To: <87mu3zpfez.fsf@bernoul.li> (message from Jonas Bernoulli on Thu, 16 Jul 2020 18:56:20 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:183111 Archived-At: > From: Jonas Bernoulli > Cc: 42397@debbugs.gnu.org > Date: Thu, 16 Jul 2020 18:56:20 +0200 > > I did just dig a bit and found bug#20323. So it turns out we did > eventually set the variable, but we did not adjust existing code to > conform to that setting. Yes, because doing that would just cause a lot of "no-op" changes, which affect the output of 'annotate', but otherwise have no real gains. Instead, we tell people to modify the whitespace as part of changes to the code they do anyway. This way, the attribution stays significant, and we eventually will get to our goal, albeit slower. > I'll change that before pushing obviously. And since this commit is > already about *fixing* whitespace, I will also *adjust* the remaining > lines to use the preferred style. Please only change the whitespace where you do make changes, for the reasons mentioned above. > It might be time to revisit the decision to not fix indentation in > bulk. Since version Git 2.23 "git blame" can ignore the effect and > presence of certain commits. I don't think we want to assume 2.23 yet. I still use 2.10 on one of my machines, and fencepost.gnu.org has 2.3.5(!). > > P.S. Why do you CC yourself on every message? It causes the Reply to > > name you twice, so you will get 2 copies of them. Is this what you > > want? > > Hmmm. Because that's not the behavior I experience. Without that > explicit CC I get the message zero times (git send-email does not put > them into the local maildir and debbugs does not appear to be echoing my > own messages back to me). With that CC I get the messages exactly once. > Maybe you experience something else because debbugs sends *all* message > to you, not just your own? I was talking about the responses. The response goes to the address in From and also to those in CC. Thus, responding to messages sent by you will always send you a copy, because you appear in From.