From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44320: [PATH] [27.1] Make sure send-string-to-terminal send all contents Date: Mon, 02 Nov 2020 18:07:13 +0200 Message-ID: <83zh3zd9ou.fsf@gnu.org> References: <5f9b49e9.1c69fb81.72b0f.80d6@mx.google.com> <83ft5wb0jz.fsf@gnu.org> <87mu03j3cv.fsf@gnus.org> <83v9eralri.fsf@gnu.org> <87v9en6axf.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3490"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44320@debbugs.gnu.org, lin.sun@zoom.us To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 02 17:08:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZcNS-0000kb-PE for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Nov 2020 17:08:14 +0100 Original-Received: from localhost ([::1]:60942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZcNR-000188-KT for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Nov 2020 11:08:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZcNG-00015Y-Fo for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 11:08:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58995) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZcNG-000618-5X for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 11:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZcNF-0008IO-U2 for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 11:08:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Nov 2020 16:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44320 X-GNU-PR-Package: emacs Original-Received: via spool by 44320-submit@debbugs.gnu.org id=B44320.160433325131846 (code B ref 44320); Mon, 02 Nov 2020 16:08:01 +0000 Original-Received: (at 44320) by debbugs.gnu.org; 2 Nov 2020 16:07:31 +0000 Original-Received: from localhost ([127.0.0.1]:42306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZcMk-0008HZ-Q3 for submit@debbugs.gnu.org; Mon, 02 Nov 2020 11:07:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZcMj-0008HN-IV for 44320@debbugs.gnu.org; Mon, 02 Nov 2020 11:07:29 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49119) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZcMe-0005sD-AC; Mon, 02 Nov 2020 11:07:24 -0500 Original-Received: from [176.228.60.248] (port=3083 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kZcMc-0000UW-Vo; Mon, 02 Nov 2020 11:07:23 -0500 In-Reply-To: <87v9en6axf.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 02 Nov 2020 16:22:20 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192543 Archived-At: > From: Lars Ingebrigtsen > Cc: Eli Zaretskii , "44320@debbugs.gnu.org" > <44320@debbugs.gnu.org> > Date: Mon, 02 Nov 2020 16:22:20 +0100 > > > send to terminal. > > (send-string-to-terminal > > (with-temp-buffer > > (insert-file-contents "testing.six") > > (buffer-string))) > > Thanks; the testing.six file is more than 4096 bytes long, so it's not > surprising that this use case triggers the bug. My guess is that we > haven't had reports about this before just because it's a pretty unusual > use case, and your proposed patch seems like the correct solution here. What is the significance of 4K bytes in this case? Is 'fwrite' documented not to write more than that? I couldn't find such documentation. And if 4KB is a limitation, then what does ERESTARTSYS have to do with this? Anyway, if we need to fix calls to 'fwrite', we should provide something similar to emacs_write, and use it everywhere we use 'fwrite' now.