all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jared Finder <jared@finder.org>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: mouse-face and help echo support for xterm mouse
Date: Fri, 06 Nov 2020 09:39:37 +0200	[thread overview]
Message-ID: <83zh3v7x3a.fsf@gnu.org> (raw)
In-Reply-To: <a8244e44edad66fe2edc62c42dfaff16@finder.org> (message from Jared Finder on Thu, 05 Nov 2020 22:46:32 -0800)

> Date: Thu, 05 Nov 2020 22:46:32 -0800
> From: Jared Finder <jared@finder.org>
> Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
> 
> >>  (defface mode-line-highlight
> >> -  '((((class color) (min-colors 88))
> >> +  '((((type graphic) (class color) (min-colors 88))
> >>       :box (:line-width 2 :color "grey40" :style released-button))
> > 
> > I don't think I understand the rationale.  With TTYs supporting many
> > colors nowadays, and mode-line-highlight available on TTYs, what is
> > the problem you tried to fix here?
> 
> Are there any TTYs that support :box?  None of the platforms I tested 
> locally on do, they instead just ignore the :box aspect of any face.

That's true, but having conditions where they aren't necessary is not
good for maintenance, because they aren't future-proof: they will need
changes should someone implement the :box attribute for TTYs.  We've
bumped into such problems many times during the last two decades: as
more and more display features (colors, menus, mouse) became supported
on TTYs, we time after time found them not working in some package,
because someone arbitrarily disabled that for TTYs on the assumption
that "TTYs cannot possibly do that".  So attributes that are silently
and harmlessly ignored should not in general be disabled.

If you want, we can add a more reasonable condition, using the
'supports' keyword, requesting specifically support for the :box
attribute.

Thanks.



  reply	other threads:[~2020-11-06  7:39 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-01  5:46 mouse-face and help echo support for xterm mouse Jared Finder via Emacs development discussions.
2020-11-01 13:39 ` Stefan Monnier
2020-11-01 15:56   ` Jared Finder via Emacs development discussions.
2020-11-04  6:54     ` Jared Finder via Emacs development discussions.
2020-11-04 14:13       ` Stefan Monnier
2020-11-04 15:46         ` Eli Zaretskii
2020-11-04 15:56           ` Stefan Monnier
2020-11-04 17:54             ` Jared Finder via Emacs development discussions.
2020-11-04 18:47               ` Stefan Monnier
2020-11-04 18:51                 ` Eli Zaretskii
2020-11-04 19:05                   ` Stefan Monnier
2020-11-04 19:10                     ` Jared Finder via Emacs development discussions.
2020-11-04 15:19       ` Eli Zaretskii
2020-11-05  8:15   ` Jared Finder via Emacs development discussions.
2020-11-05 14:45     ` Stefan Monnier
2020-11-05 19:58       ` Jared Finder via Emacs development discussions.
2020-11-05 20:18         ` Stefan Monnier
2020-11-06  5:23           ` Jared Finder via Emacs development discussions.
2020-11-06  6:00             ` Eli Zaretskii
2020-11-06  6:46               ` Jared Finder via Emacs development discussions.
2020-11-06  7:39                 ` Eli Zaretskii [this message]
2020-11-07  1:22                   ` Jared Finder via Emacs development discussions.
2020-11-14 12:38                     ` Eli Zaretskii
2020-11-14 12:35                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zh3v7x3a.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jared@finder.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.