From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master a08320f: * lisp/disp-table.el (make-glyph-code): Remove
 obsolete comment.
Date: Mon, 09 Nov 2020 21:46:32 +0200
Message-ID: <83zh3q2u07.fsf@gnu.org>
References: <20201109171613.6680.13417@vcs0.savannah.gnu.org>
 <20201109171614.766A220A27@vcs0.savannah.gnu.org> <831rh248xu.fsf@gnu.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="1909"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: p.stephani2@gmail.com, phst@google.com
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 09 20:47:08 2020
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kcD88-0000OQ-2o
	for ged-emacs-devel@m.gmane-mx.org; Mon, 09 Nov 2020 20:47:08 +0100
Original-Received: from localhost ([::1]:45006 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1kcD87-0004nj-3Y
	for ged-emacs-devel@m.gmane-mx.org; Mon, 09 Nov 2020 14:47:07 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40360)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1kcD7U-0004MU-58
 for emacs-devel@gnu.org; Mon, 09 Nov 2020 14:46:28 -0500
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49791)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1kcD7T-0001pQ-9U; Mon, 09 Nov 2020 14:46:27 -0500
Original-Received: from [176.228.60.248] (port=3108 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1kcD7S-0002qc-53; Mon, 09 Nov 2020 14:46:27 -0500
In-Reply-To: <831rh248xu.fsf@gnu.org> (message from Eli Zaretskii on Mon, 09
 Nov 2020 21:38:37 +0200)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:258954
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/258954>

> Date: Mon, 09 Nov 2020 21:38:37 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: phst@google.com, emacs-devel@gnu.org
> 
> > -  ;; Due to limitations on Emacs integer values, faces with
> > -  ;; face id greater than 512 are silently ignored.
> >    (if (not face)
> >        char
> >      (let ((fid (face-id face)))
> 
> Is this comment really obsolete?  We still need to be able to pack a
> face ID and a 22-bit character codepoint into a single fixnum, which
> could be a 32-bit data type.  See GLYPH_CODE_CHAR, GLYPH_CODE_FACE,
> and SET_GLYPH_FROM_GLYPH_CODE on dispextern.h.

Sorry, ignore me.