Re: master a08320f: * lisp/disp-table.el (make-glyph-code): Remove obsolete comment.

Re: master a08320f: * lisp/disp-table.el (make-glyph-code): Remove obsolete comment.

[Eli Zaretskii]

> Auto-Submitted: auto-generated
> Date: Mon,  9 Nov 2020 12:16:14 -0500 (EST)
> From: p.stephani2@gmail.com (Philipp Stephani)
> 
> branch: master
> commit a08320f7234685cd84a18040556fd3f7eaacaf45
> Author: Philipp Stephani <phst@google.com>
> Commit: Philipp Stephani <phst@google.com>
> 
>     * lisp/disp-table.el (make-glyph-code): Remove obsolete comment.
> ---
>  lisp/disp-table.el | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/lisp/disp-table.el b/lisp/disp-table.el
> index 2e88d35..70343a3 100644
> --- a/lisp/disp-table.el
> +++ b/lisp/disp-table.el
> @@ -220,8 +220,6 @@ for a graphical frame."
>  ;;;###autoload
>  (defun make-glyph-code (char &optional face)
>    "Return a glyph code representing char CHAR with face FACE."
> -  ;; Due to limitations on Emacs integer values, faces with
> -  ;; face id greater than 512 are silently ignored.
>    (if (not face)
>        char
>      (let ((fid (face-id face)))

Is this comment really obsolete?  We still need to be able to pack a
face ID and a 22-bit character codepoint into a single fixnum, which
could be a 32-bit data type.  See GLYPH_CODE_CHAR, GLYPH_CODE_FACE,
and SET_GLYPH_FROM_GLYPH_CODE on dispextern.h.

Re: master a08320f: * lisp/disp-table.el (make-glyph-code): Remove obsolete comment.

[Eli Zaretskii]

> Date: Mon, 09 Nov 2020 21:38:37 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: phst@google.com, emacs-devel@gnu.org
> 
> > -  ;; Due to limitations on Emacs integer values, faces with
> > -  ;; face id greater than 512 are silently ignored.
> >    (if (not face)
> >        char
> >      (let ((fid (face-id face)))
> 
> Is this comment really obsolete?  We still need to be able to pack a
> face ID and a 22-bit character codepoint into a single fixnum, which
> could be a 32-bit data type.  See GLYPH_CODE_CHAR, GLYPH_CODE_FACE,
> and SET_GLYPH_FROM_GLYPH_CODE on dispextern.h.

Sorry, ignore me.

Re: master a08320f: * lisp/disp-table.el (make-glyph-code): Remove obsolete comment.

[Philipp Stephani]

Am Mo., 9. Nov. 2020 um 20:38 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
>
> > Auto-Submitted: auto-generated
> > Date: Mon,  9 Nov 2020 12:16:14 -0500 (EST)
> > From: p.stephani2@gmail.com (Philipp Stephani)
> >
> > branch: master
> > commit a08320f7234685cd84a18040556fd3f7eaacaf45
> > Author: Philipp Stephani <phst@google.com>
> > Commit: Philipp Stephani <phst@google.com>
> >
> >     * lisp/disp-table.el (make-glyph-code): Remove obsolete comment.
> > ---
> >  lisp/disp-table.el | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/lisp/disp-table.el b/lisp/disp-table.el
> > index 2e88d35..70343a3 100644
> > --- a/lisp/disp-table.el
> > +++ b/lisp/disp-table.el
> > @@ -220,8 +220,6 @@ for a graphical frame."
> >  ;;;###autoload
> >  (defun make-glyph-code (char &optional face)
> >    "Return a glyph code representing char CHAR with face FACE."
> > -  ;; Due to limitations on Emacs integer values, faces with
> > -  ;; face id greater than 512 are silently ignored.
> >    (if (not face)
> >        char
> >      (let ((fid (face-id face)))
>
> Is this comment really obsolete?  We still need to be able to pack a
> face ID and a 22-bit character codepoint into a single fixnum, which
> could be a 32-bit data type.  See GLYPH_CODE_CHAR, GLYPH_CODE_FACE,
> and SET_GLYPH_FROM_GLYPH_CODE on dispextern.h.

It definitely worked for me with a face ID over 800. Also there's the
second codepath with a glyph code that is a cons, supporting all
fixnums as face IDs.

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich. Falls Sie diese fälschlicherweise
erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes
weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich
bitte wissen, dass die E-Mail an die falsche Person gesendet wurde.

This e-mail is confidential. If you received this communication by
mistake, please don’t forward it to anyone else, please erase all
copies and attachments, and please let me know that it has gone to the
wrong person.