From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [patch] add support for ibm278 Date: Fri, 25 Dec 2020 16:02:29 +0200 Message-ID: <83zh22m1ai.fsf@gnu.org> References: <878s9nb4cy.fsf@asteroid.bittivirhe.fi> <83lfdnnid8.fsf@gnu.org> <87v9cq9lm5.fsf@asteroid.bittivirhe.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26890"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Timo =?utf-8?Q?Myyr=C3=A4?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 25 15:04:04 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ksnhM-0006t6-Dx for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Dec 2020 15:04:04 +0100 Original-Received: from localhost ([::1]:49448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ksnhL-0003a5-Go for ged-emacs-devel@m.gmane-mx.org; Fri, 25 Dec 2020 09:04:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50222) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ksngB-00037o-DI for emacs-devel@gnu.org; Fri, 25 Dec 2020 09:02:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41652) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ksng9-00061a-VV; Fri, 25 Dec 2020 09:02:50 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2827 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ksng9-0004v5-Df; Fri, 25 Dec 2020 09:02:49 -0500 In-Reply-To: <87v9cq9lm5.fsf@asteroid.bittivirhe.fi> (message from Timo =?utf-8?Q?Myyr=C3=A4?= on Fri, 25 Dec 2020 13:21:54 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:261748 Archived-At: > From: Timo Myyrä > Cc: emacs-devel@gnu.org > Date: Fri, 25 Dec 2020 13:21:54 +0200 > > Eli Zaretskii [2020-12-24, 20:56 +0200]: > > >> From: Timo Myyrä > >> Date: Thu, 24 Dec 2020 17:39:25 +0200 > >> > >> add support for ebcdic code page ibm278 for finnish/swedish > > > > Thanks. I think this needs a couple of aliases, like cp278, > > ebcdic-se-fi, etc. > > > > Also, if we are going to add this variant of EBCDIC, might as well add > > the other IBM2xx codepages as well (with the respective aliases). > > Ok, I'm not sure about other ebcdic code pages but heres them added as > well. Thanks, I installed this on the master branch, minus the charset aliases, which I think are not needed (as opposed to coding-system aliases). Please in the future accompany the patches with a ChangeLog-style commit log message which names the files and the functions where you made the changes. (I provided this for you in this case.) See the file CONTRIBUTE for the details about that. > I based my naming from IBM support docs and libintl-perl CPAN library: > https://www.ibm.com/support/knowledgecenter/en/SS3JRN_7.2.1/com.ibm.itcama.doc_7.2.1/oracleextended/fac_oracle_codepage.html > https://metacpan.org/release/libintl-perl FTR, I think the official site to look up this info is here: https://www.iana.org/assignments/character-sets/character-sets.xhtml