all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Timo Myyrä" <timo.myyra@bittivirhe.fi>
Cc: emacs-devel@gnu.org
Subject: Re: [patch] add support for ibm278
Date: Fri, 25 Dec 2020 16:02:29 +0200	[thread overview]
Message-ID: <83zh22m1ai.fsf@gnu.org> (raw)
In-Reply-To: <87v9cq9lm5.fsf@asteroid.bittivirhe.fi> (message from Timo Myyrä on Fri, 25 Dec 2020 13:21:54 +0200)

> From: Timo Myyrä <timo.myyra@bittivirhe.fi>
> Cc: emacs-devel@gnu.org
> Date: Fri, 25 Dec 2020 13:21:54 +0200
> 
> Eli Zaretskii <eliz@gnu.org> [2020-12-24, 20:56 +0200]:
> 
> >> From: Timo Myyrä <timo.myyra@bittivirhe.fi>
> >> Date: Thu, 24 Dec 2020 17:39:25 +0200
> >> 
> >> add support for ebcdic code page ibm278 for finnish/swedish
> >
> > Thanks.  I think this needs a couple of aliases, like cp278,
> > ebcdic-se-fi, etc.
> >
> > Also, if we are going to add this variant of EBCDIC, might as well add
> > the other IBM2xx codepages as well (with the respective aliases).
> 
> Ok, I'm not sure about other ebcdic code pages but heres them added as
> well.

Thanks, I installed this on the master branch, minus the charset
aliases, which I think are not needed (as opposed to coding-system
aliases).

Please in the future accompany the patches with a ChangeLog-style
commit log message which names the files and the functions where you
made the changes.  (I provided this for you in this case.)  See the
file CONTRIBUTE for the details about that.

> I based my naming from IBM support docs and libintl-perl CPAN library:
> https://www.ibm.com/support/knowledgecenter/en/SS3JRN_7.2.1/com.ibm.itcama.doc_7.2.1/oracleextended/fac_oracle_codepage.html
> https://metacpan.org/release/libintl-perl

FTR, I think the official site to look up this info is here:

  https://www.iana.org/assignments/character-sets/character-sets.xhtml



      reply	other threads:[~2020-12-25 14:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-24 15:39 [patch] add support for ibm278 Timo Myyrä
2020-12-24 18:56 ` Eli Zaretskii
2020-12-25 11:21   ` Timo Myyrä
2020-12-25 14:02     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zh22m1ai.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=timo.myyra@bittivirhe.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.