From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master 050b830 3/3: Do interactive mode tagging for finder.el
Date: Fri, 19 Mar 2021 10:15:17 +0200
Message-ID: <83zgyzeezu.fsf@gnu.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="30777"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Stefan Kangas <stefan@marxist.se>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 19 09:15:57 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lNAIW-0007sH-1e
	for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Mar 2021 09:15:56 +0100
Original-Received: from localhost ([::1]:50466 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lNAIV-0000qJ-3J
	for ged-emacs-devel@m.gmane-mx.org; Fri, 19 Mar 2021 04:15:55 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50984)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1lNAHz-0000RH-3z
 for emacs-devel@gnu.org; Fri, 19 Mar 2021 04:15:23 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:46157)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1lNAHy-0003aM-JV; Fri, 19 Mar 2021 04:15:22 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1131
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1lNAHu-0006PE-AL; Fri, 19 Mar 2021 04:15:22 -0400
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:266588
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/266588>

> @@ -423,7 +423,7 @@ FILE should be in a form suitable for passing to `locate-library'."
>  
>  (defun finder-mouse-select (event)
>    "Select item in a Finder buffer with the mouse."
> -  (interactive "e")
> +  (interactive "e" finder-mode)
>    (with-current-buffer (window-buffer (posn-window (event-start event)))
>      (goto-char (posn-point (event-start event)))
>      (finder-select)))

I think this part is dangerous: mouse commands are not necessarily
issued with the buffer on which they operate being current, so
conditioning such commands on the mode of the current buffer is
ill-advised.  Even if currently this marking doesn't produce any
visible problems (does it?), it could do so in the future, if and when
we decide to base more on this tagging than we do now.

I think this part should be reverted, and in the future commands bound
to mouse clicks should not be tagged with any major mode.

Thanks.