From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: master 3665735: Sort the items in 'mode-line-mode-menu' before
 displaying the menu
Date: Thu, 24 Jun 2021 19:22:59 +0300
Message-ID: <83zgvfs04c.fsf@gnu.org>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="15251"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: larsi@gnus.org (Lars Ingebrigtsen)
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 24 18:24:37 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lwS9c-0003rh-SF
	for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Jun 2021 18:24:36 +0200
Original-Received: from localhost ([::1]:43530 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lwS9b-0006b7-S3
	for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Jun 2021 12:24:35 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56832)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1lwS8K-0004sO-3z
 for emacs-devel@gnu.org; Thu, 24 Jun 2021 12:23:16 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49112)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1lwS8J-0004St-KR; Thu, 24 Jun 2021 12:23:15 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4448
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1lwS8G-00015d-Ip; Thu, 24 Jun 2021 12:23:13 -0400
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:271006
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/271006>

>  (defvar mode-line-major-mode-keymap
>    (let ((map (make-sparse-keymap)))
>      (bindings--define-key map [mode-line down-mouse-1]
>        `(menu-item "Menu Bar" ignore
>          :filter ,(lambda (_) (mouse-menu-major-mode-map))))
>      (define-key map [mode-line mouse-2] 'describe-mode)
> -    (define-key map [mode-line down-mouse-3] mode-line-mode-menu)
> +    (bindings--define-key map [mode-line down-mouse-3]
> +      `(menu-item "Menu Bar" ,mode-line-mode-menu
> +        :filter bindings--sort-keymap))
>      map) "\
>  Keymap to display on major mode.")
>  
>  (defvar mode-line-minor-mode-keymap
> -  (let ((map (make-sparse-keymap)))
> +  (let ((map (make-sparse-keymap))
> +        (mode-menu-binding
> +         `(menu-item "Menu Bar" ,mode-line-mode-menu
> +           :filter bindings--sort-keymap)))
>      (define-key map [mode-line down-mouse-1] 'mouse-minor-mode-menu)

Why does this use "Menu Bar" as the first arg of menu-item?