all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: salvino@coderedcorp.com, emacs-devel@gnu.org
Subject: Re: Dark mode on Windows
Date: Mon, 25 Oct 2021 15:37:22 +0300	[thread overview]
Message-ID: <83zgqx1drx.fsf@gnu.org> (raw)
In-Reply-To: <87cznty61p.fsf@yahoo.com> (message from Po Lu on Mon, 25 Oct 2021 14:25:38 +0800)

> From: Po Lu <luangruo@yahoo.com>
> Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
> Date: Mon, 25 Oct 2021 14:25:38 +0800
> 
> Vince Salvino <salvino@coderedcorp.com> writes:
> 
> > I originally tried dynamically loading dwmapi.dll, and it cannot be
> > done dynamically. It will simply not load. I spent a lot of time
> > head-scratching in gdb to figure this out. From what I read, it
> > behaves a bit differently than other DLLs and has to be linked. This
> > is also my first foray into Win32 programming, so I have exactly zero
> > experience with any of this stuff, and could be wrong.
> 
> Some searching reveals that dwmapi.dll is apparently already loaded into
> every program on systems that have it.

If it is already loaded, LoadLibrary should just increase its
reference count, but will return a valid handle.  We do that all the
time in Emacs, for example when using LoadLibrary to load
kernel32.dll, which on modern Windows systems is always loaded.

> So you probably just need a way to get the address of the symbol for the
> function you want to use.

You cannot get an address without a handle to the DLL, and that's what
LoadLibrary gives you.  An alternative is to use GetModuleHandle, if
we know the library is already loaded.

The main point is that if we link with -ldmwapi, i.e. link statically
against the DLL, the resulting Emacs binary will refuse to start on
systems where this DLL is not available.  So this means in practice we
will be unable to provide precompiled binaries that run on any
supported Windows system.



  reply	other threads:[~2021-10-25 12:37 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-24 22:27 Dark mode on Windows Vince Salvino
2021-10-25  1:17 ` Po Lu
2021-10-25  1:22   ` Po Lu
2021-10-25  3:25     ` Óscar Fuentes
2021-10-25  4:32       ` Po Lu
2021-10-25 12:31         ` Óscar Fuentes
2021-10-26  5:02           ` Po Lu
2021-10-25  4:14     ` Vince Salvino
2021-10-25  4:27       ` Po Lu
2021-10-25  5:20         ` Vince Salvino
2021-10-25  6:25           ` Po Lu
2021-10-25 12:37             ` Eli Zaretskii [this message]
2021-10-25 15:44               ` Vince Salvino
2021-10-25 16:34                 ` Eli Zaretskii
2021-10-25 12:15           ` Eli Zaretskii
2021-10-25 13:17       ` Eric S Fraga
2021-10-25  9:59   ` Alan Third
2021-10-25 11:55   ` Eli Zaretskii
2021-10-25 12:22     ` Stefan Monnier
2021-10-25 12:52       ` Eli Zaretskii
2021-10-25 16:52         ` Michael Albinus
2021-10-26  2:04         ` Po Lu
2021-10-26 12:10           ` Eli Zaretskii
2021-10-26 13:35             ` Po Lu
2021-10-26 14:11               ` Eli Zaretskii
2021-10-25 13:02       ` Óscar Fuentes
2021-10-25 13:28         ` Stefan Monnier
2021-10-25 13:56           ` Óscar Fuentes
2021-10-25 17:20             ` Stefan Monnier
2021-10-26  0:56     ` Po Lu
2021-10-26  1:08       ` Óscar Fuentes
2021-10-26  2:02         ` Po Lu
2021-10-26 12:09           ` Eli Zaretskii
2021-10-27  0:36             ` Po Lu
2021-10-27 12:02               ` Eli Zaretskii
2021-10-26 12:08       ` Eli Zaretskii
2021-10-27  0:37         ` Po Lu
2021-10-27 14:36   ` Richard Stallman
2021-10-27 16:28     ` Vince Salvino
2021-10-27 19:49       ` Óscar Fuentes
2021-10-28  6:19         ` Eli Zaretskii
2021-10-25 12:42 ` Óscar Fuentes
2021-10-25 15:45   ` Vince Salvino
2021-10-26  4:29 ` Vince Salvino
2021-10-26  7:32   ` Po Lu
2021-10-26 14:03     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zgqx1drx.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=luangruo@yahoo.com \
    --cc=salvino@coderedcorp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.