From: Eli Zaretskii <eliz@gnu.org>
To: Sergey Vinokurov <serg.foo@gmail.com>
Cc: 53242@debbugs.gnu.org
Subject: bug#53242: [PATCH] unify reads from local_var_alist
Date: Fri, 14 Jan 2022 10:08:49 +0200 [thread overview]
Message-ID: <83zgny20z2.fsf@gnu.org> (raw)
In-Reply-To: <50d65dbc-f3d6-86fb-6a7c-9200a6525ec2@gmail.com> (message from Sergey Vinokurov on Fri, 14 Jan 2022 00:23:42 +0000)
> Date: Fri, 14 Jan 2022 00:23:42 +0000
> From: Sergey Vinokurov <serg.foo@gmail.com>
>
> I've noticed that local_var_alist field of the buffer structure is
> accessed inconsistently. Sometimes it's Fassoc, sometimes it's Fassq and
> other times it's assq_no_quit and even an explicit loop.
>
> I think it's safe to unify all the accesses via assq_no_quit since it's
> an internaly maintained alist that definitely has no cycles and elements
> are cons cells with symbol as their car.
How long can local_var_alist be? This change will not allow the user
to C-g from a long search. Do we care? How about using Fassq
consistently instead?
next prev parent reply other threads:[~2022-01-14 8:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 0:23 bug#53242: [PATCH] unify reads from local_var_alist Sergey Vinokurov
2022-01-14 7:49 ` Lars Ingebrigtsen
2022-01-14 8:08 ` Eli Zaretskii [this message]
2022-01-14 8:33 ` Lars Ingebrigtsen
2022-01-14 18:37 ` Sergey Vinokurov
2022-01-14 19:01 ` Eli Zaretskii
2022-01-14 21:01 ` Sergey Vinokurov
2022-01-15 7:32 ` Eli Zaretskii
2022-01-15 11:41 ` Sergey Vinokurov
2022-01-15 16:02 ` Corwin Brust
2022-01-15 17:54 ` Sergey Vinokurov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zgny20z2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=53242@debbugs.gnu.org \
--cc=serg.foo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.